qa.sh stripped warning

[Mathieu Arnold]

Le 12/10/2016 à 16:29, Kyle Evans a écrit :
> Hello!
>
> I've got a port with a dozen+ ELF binaries for microcontroller
> firmware that I don't think I should be stripping, but qa.sh does not
> like this. They're *.elf and *.lib files, so I don't know that adding
> these to the general exception of `find` in stripped() is necessarily
> a good idea, but it seems like a way to add exceptions for this would
> it be a good idea, whether it be through some setting in the port or
> on a case-by-case basis in the pkg-plist.. thoughts?
>
> My main concern here is that I don't intend to strip these, but the
> comment for stripped() would leave me to believe that there's a chance
> these warnings could eventually turn into errors, and I don't want
> this to be the case if it's not something that should be stripped.

The warning will never be turned into errors. Maybe add a comment to the
makefile saying that files must not be stripped. Maybe a bit like go
ports do it, something like:

STRIP= # Elf firmwares, do not strip


Which also disables the qa warnings.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20161012/c01edcf1/attachment.sig>