iso-codes

[Koop Mast]

On Mon, 2016-08-22 at 02:42 +1000, Kubilay Kocak wrote:
> On 21/08/2016 8:49 PM, Lena at lena.kiev.ua wrote:
> > 
> > Does the latest version of the port misc/iso-codes really need
> > python 3
> > for build?
> > 
> > Python 2.7 not enough?
> > 
> > https://svnweb.freebsd.org/ports/head/misc/iso-codes/Makefile?r1=40
> > 9133&r2=420522
> A grep of the sources shows many references to python3 (calling
> script),
> including:

I think Lena is more wondering about the new build requirement off
python3. As your pointed out the scripts require python3, there is not
much I can do about that.

I also don't see much point in trying to bash the scripts into shape
using the full version (3.4 in this case) python version since they are
only used during build time.

-Koop

> bin/validate_json_data.py:#!/usr/bin/env python3
> bin/xml_from_json.py:#!/usr/bin/env python3
> bin/pot_from_json.py:#!/usr/bin/env python3
> bin/check_valid_utf8.py:#!/usr/bin/env python3
> 
> And in the build system:
> 
> common.mk:      python3 $(top_srcdir)/bin/pot_from_json.py $(DOMAIN)
> $(top_srcdir)/data
> common.mk:      python3 $(top_srcdir)/bin/xml_from_json.py $(DOMAIN)
> $(top_srcdir)/data $@
> common.mk:      python3 $(top_srcdir)/bin/check_valid_utf8.py
> $(pofiles)
> 
> I didn't check whether this was a recent change (new in 3.69) or not.
> 
> These could/should be updated to use python3.x scripts directly
> instead,
> rather then the python3 symlink provided by lang/python3. This could
> be
> done with judicious use of USES=shebangfix
> 
> Maintainer CC'd
> 
> Hope that helps Lena
> 
> ./koobs