Is staging a port really this simple?

[John Marino]

On 5/25/2014 09:09, Zsolt Udvari wrote:
> 2014-05-25 7:04 GMT+02:00 Perry Hutchison <perryh at pluto.rain.com>:
>>  post-install:
>> -       @[ -f ${PREFIX}/etc/diskcheckd.conf ] \
>> -               || ${CP} -p ${PREFIX}/etc/diskcheckd.conf.sample \
>> -                       ${PREFIX}/etc/diskcheckd.conf
>> +       @[ -f ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf ] \
>> +               || ${CP} -p ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample \
>> +                       ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf
> Your condition is unneeded.
> You don't need check the existence of
> ${STAGEDIR}${PREFIX}/etc/distcheckd.conf because you'll copy it, the
> ${STAGEDIR} are empty!!!!
> The reason of "old" check was: shouldn't overwrite the existing
> distcheckd.conf (in system, not STAGEDIR). These checks are
> unnecessary, the 'pkg' does it.
> 


no, the @sample keyword in pkg-plist does that (replacing other lines
there).  pkg doesn't do this by itself, it needs to be told.

John