foomatic-rip and foo2zjs

[Stefan Bethke]

Am 25.04.2014 um 15:20 schrieb Robert Backhaus <robbak at robbak.com>:

> Anyway, here's a backtrace: - but the pointed line, 1200, just looks wrong - 
> 
> int fd = mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built - Yup, that's it. Here's the patch:
> 
> --- foomaticrip.c.orig  2014-04-25 23:16:06.000000000 +1000
> +++ foomaticrip.c       2014-04-25 23:16:47.000000000 +1000
> @@ -1197,7 +1197,7 @@
>          debug = 1;
>  
>      if (debug) {
> -       int fd = mkstemp (LOG_FILE "-XXXXXX.log");
> +       int fd = mkstemp ("LOG_FILE-XXXXXX.log");
>         if (fd != -1)
>             logh = fdopen(fd, "w");
>         else

Sorry, that patch does’t look right to me. LOG_FILE should be a define that get’s concatenated with the string literal. Since this is compile-time, I don’t see how this would lead to a runtime error, unless LOG_FILE was defined to some unusual value.


Stefan

-- 
Stefan Bethke <stb at lassitu.de>   Fon +49 151 14070811




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20140425/1cfdb871/attachment.sig>