[FIX] Re: FreeBSD Port: security/sshguard-pf

[Chris Rees]

On Mon, 14 Apr 2014 12:59:21 +0200, Stefan Esser wrote
> Am 14.04.2014 10:25, schrieb Benjamin Podszun:
> > I'd say this is a bug in sshguard: Failing to start shouldn't exit with 0.
> > That said, it first and foremost is a bug in the port.
> > 
> > Looking at the rc script and the diff [1] the problem's easy enough:
> > ${sshguard_pidfile} is passed as parameter to -i, but isn't set in the
> > script/has no default value. Either the related line from the previous
> > revision should be revived or the substitution should change to use
> > ${pidfile}, which _is_ set.
> 
> The attached diff fixes the problems in the sshguard rc file. I have
> replaced occurences of ${name} with "sshguard", in accordance with
> newer rc script style conventions. The diff has to be applied within
> the files sub-directory of the sshguard port.
> 
> The other problems of this port (see previous mail) are not fixed and
> should still be addressed ...

Sorry, I thought you'd committed this!

Thanks very much for the patch-- the trick with \$ to delay evaluation was
more elegant than my plan to stick that line inside _prestart.

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.