Help understanding ports tinderbox failure report?
David Wolfskill
david at catwhisker.org
Mon Sep 23 00:55:35 UTC 2013
Back in July, I filed PR ports/180642 (as the port maintainer for
astro/gpsman) to update that port from 6.4.4 to 6.4.4.1.
astro/gpsman is a tcl/Tk application; recently, a request was made to
update such ports from "USE_TK_RUN" to "USES+= tk,run" (for example.
In the process of doing that, I discovered that the patch in ports/180642
had never been committed.
So I took a look at
<http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180642>, and found --
much to my surprise -- that a tinderbox run had apparently encountered a
problem if "NOPORTDOCS=yes" had been specified. (I had not been
informed of this because there was a typo in my email address.)
I'm not familiar with interpreting ports tinderbox reports, but the
complaint appears to be that if "NOPORTDOCS=yes" is specified, the
deinstallation of the port leaves (lots of) files behind.
Now, I don't have ports-mgmt/tinderbox installed on my laptop; "make
missing" shows that several prerequisite ports are not installed. But
the application is fairly stand-alone: I can afford to deinstall &
reinstall it. So I deinstalled the port, appended "NOPORTDOCS=yes" to
/etc/make.conf, installed the port (no problem, except that the
pkg-message advised me to go look at some files that weren't installed
because of the "NOPORTDOCS=yes"). I then used pkg_delete to remove the
port, and there was no trace of the files that tinderbox whined about.
So I'm fairly confused at this point.
I recall having paid a moderate amount of attention to ensuring that the
pkg-plist was constructed properly, but looking at the port, it's not
there. A review of the svn log for the Makefile shows the entry:
------------------------------------------------------------------------
r295739 | jgh | 2012-04-30 14:22:11 -0700 (Mon, 30 Apr 2012) | 8 lines
- Update to 6.4.3 [1]
- while here, drop pkg-plist and use PORT{DOCS,DATA} [2]
- substitute on pkg-message, and actually show it [2]
- tighten Makefile instructions, and reduce number of MKDIRS [2]
PR: ports/167432
Submitted by: maintainer, david at catwhisker.org [1], jgh@[2]
------------------------------------------------------------------------
I did tweak the Makefile a bit so if "NOPORTDOCS=yes" is specified,
it won't add "pkg-message" to SUB_FILES; thus, it no longer attempts
to advise folks who specified "NOPORTDOCS=yes" to go look at files
that aren't there. (I think that's an improvement.)
And whatever caused the problem that tinderbox is reporting, I can't
really imagine that it originated with the patch provided for the 6.4.4
-> 6.4.4.1 upgrade.
I've attached a revised patch, to:
* Perform the 6.4.4 -> 6.4.4.1 upgrade.
* Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+= tk:wrapper,run".
* Avoid showing the pkg-message if NOPORTDOCS is defined.
(The pkg-message merely directs the installer to look at installed port
documentation, so it's not very useful if NOPORTDOCS is defined.)
How can I fix this so it's commitable?
Peace,
david
--
David H. Wolfskill david at catwhisker.org
Taliban: Evil cowards with guns afraid of truth from a 14-year old girl.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
-------------- next part --------------
Index: gpsman/Makefile
===================================================================
--- gpsman/Makefile (revision 327861)
+++ gpsman/Makefile (working copy)
@@ -1,8 +1,8 @@
-# Created by: David Wolfskill
+# Created by: David Wolfskill <david at catwhisker.org>
# $FreeBSD$
PORTNAME= gpsman
-PORTVERSION= 6.4.4
+PORTVERSION= 6.4.4.1
CATEGORIES= astro tk geography
MASTER_SITES= SF/${PORTNAME}/distrib
EXTRACT_SUFX= .tgz
@@ -10,11 +10,12 @@
MAINTAINER= david at catwhisker.org
COMMENT= A Tcl/Tk-based GPS management utility
-USE_TK_RUN= 84+
+USES+= tk:wrapper,run
WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
+.if !defined(NOPORTDOCS)
SUB_FILES= pkg-message
-NO_STAGE= yes
+.endif
NO_BUILD= yes
PORTDOCS= *
PORTDATA= *
Index: gpsman/distinfo
===================================================================
--- gpsman/distinfo (revision 327861)
+++ gpsman/distinfo (working copy)
@@ -1,2 +1,2 @@
-SHA256 (gpsman-6.4.4.tgz) = b7a6f94d24dfd47507240fd0f1e3db94305ca8485c31db3a9fbf9637656027fe
-SIZE (gpsman-6.4.4.tgz) = 1418214
+SHA256 (gpsman-6.4.4.1.tgz) = 214a8dbb3d8e0b0b798fc0cb1a422764d8747cd431105d55d54308d5deb9910c
+SIZE (gpsman-6.4.4.1.tgz) = 1417223
Index: gpsman/files/patch-gpsman.tcl
===================================================================
--- gpsman/files/patch-gpsman.tcl (revision 327861)
+++ gpsman/files/patch-gpsman.tcl (working copy)
@@ -3,14 +3,6 @@
diff -ruN gpsman.tcl gpsman.tcl
--- gpsman.tcl Tue May 9 02:37:24 2006
+++ gpsman.tcl Wed May 10 17:56:02 2006
-@@ -1,6 +1,6 @@
- #!/bin/sh
- # This is a Tcl/Tk script to be interpreted by wish (Tk8.3 or better): \
--exec wish "$0" -- "$@"
-+exec wish8.4 "$0" -- "$@"
-
- #
- # gpsman --- GPS Manager: a manager for GPS receiver data
@@ -247,7 +247,7 @@
}
Index: gpsman/pkg-descr
===================================================================
--- gpsman/pkg-descr (revision 327861)
+++ gpsman/pkg-descr (working copy)
@@ -5,4 +5,4 @@
logging information in NMEA from any GPS receiver.
Author: Miguel Filgueiras
-WWW: http://gpsman.sourceforge.net/
+WWW: http://gpsman.sourceforge.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20130922/bfadba06/attachment.sig>
More information about the freebsd-ports
mailing list