More Heimdal 1.5.2 port problems

[Robert Simmons]

On Sun, May 27, 2012 at 3:33 PM, Wesley Shields <wxs at freebsd.org> wrote:
> On Sun, May 27, 2012 at 01:58:23PM -0400, Robert Simmons wrote:
>> On Sat, May 26, 2012 at 3:22 PM, Robert Simmons <rsimmons0 at gmail.com> wrote:
>> > I've found another problem with the port.
>> >
>> > kadmind and kdc both look for krb5.conf in /usr/local/etc, but
>> > kpasswdd and kstash look for it in /etc. ?This can be fixed with a
>> > symlink, but I feel like that's not the best solution. ?Ultimately,
>> > all the heimdal utilities and daemons should be looking in the same
>> > location for krb5.conf, correct?
>> >
>> > I don't see any flags for kstash or kpasswdd to change where they look
>> > for krb5.conf.
>> >
>> > I'm going to go back and compile it from source again and see if there
>> > is another configure flag that is missing from the port.
>>
>> I've attached a patch for this problem.  Please review it and make
>> sure this is the right way to fix the problem.
>
>> --- Makefile.old      2012-05-27 13:53:01.132516965 -0400
>> +++ Makefile  2012-05-27 13:54:13.928517659 -0400
>> @@ -7,7 +7,7 @@
>>
>>  PORTNAME=    heimdal
>>  PORTVERSION= 1.5.2
>> -PORTREVISION=        2
>> +PORTREVISION=        3
>>  CATEGORIES=  security ipv6
>>  MASTER_SITES=        http://www.h5l.org/dist/src/ \
>>               http://ftp.pdc.kth.se/pub/heimdal/src/ \
>> @@ -39,7 +39,8 @@
>>  CONFIGURE_ARGS+=     --with-libintl=${LOCALBASE} \
>>                       --with-readline=${DESTDIR}/usr \
>>                       --enable-pthread-support \
>> -                     --with-hdbdir=/var/db/${PORTNAME}
>> +                     --with-hdbdir=/var/db/${PORTNAME} \
>> +                     --sysconfdir=${LOCALBASE}/etc
>>  MAKE_ENV+=   INSTALL_CATPAGES=no
>
> You want to use PREFIX instead of LOCALBASE for sysconfdir.
>
> PREFIX is where the port will install into, LOCALBASE is where the
> dependencies will be looked for. It's almost always the case that PREFIX
> is the same as LOCALBASE but we should support them being different.
>
> Otherwise the patch looks sane to me. Awaiting Joerg's input before I
> commit. Thanks again!

Understood.  Here's a new patch.  Also, this particular behavior seems
odd to me, and I think I will ping Heimdal's list about this.  It
seems to me that this configure flag shouldn't be needed, or at least
all the daemons and utilities should look consistently in the same
location if this flag is not set.
-------------- next part --------------
--- Makefile.old	2012-05-27 13:53:01.132516965 -0400
+++ Makefile	2012-05-27 13:54:13.928517659 -0400
@@ -7,7 +7,7 @@
 
 PORTNAME=	heimdal
 PORTVERSION=	1.5.2
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	security ipv6
 MASTER_SITES=	http://www.h5l.org/dist/src/ \
 		http://ftp.pdc.kth.se/pub/heimdal/src/ \
@@ -39,7 +39,8 @@
 CONFIGURE_ARGS+=	--with-libintl=${LOCALBASE} \
 			--with-readline=${DESTDIR}/usr \
 			--enable-pthread-support \
-			--with-hdbdir=/var/db/${PORTNAME}
+			--with-hdbdir=/var/db/${PORTNAME} \
+			--sysconfdir=${PREFIX}/etc
 MAKE_ENV+=	INSTALL_CATPAGES=no
 
 INFO=		heimdal hx509