WITH_GCC
Andriy Gapon
avg at FreeBSD.org
Thu May 24 06:09:26 UTC 2012
on 21/05/2012 05:54 Gerald Pfeifer said the following:
> On Wed, 16 May 2012, Andriy Gapon wrote:
>>>> +CFLAGS+= ${CFLAGS.${CC}}
>>>> +CXXFLAGS+= ${CXXFLAGS.${CC}}
>>>
>>> Similarly here. Where does this come from, why is it related to
>>> the WITH_GCC versus USE_GCC patch? Can and should this be split
>>> out? How is it used and where? Where is it defined?
>>
>> This should be split out. The use case is to make it possible to set
>> something like the following in make.conf:
>>
>> CFLAGS.gcc46+= -fearlier-gcc-fails-with-this-flag-but-I-want-it-with-gcc46
>
> I see! The only question I have is whether, given there is also clang,
> this is really best suited for Mk/bsd.gcc.mk, or this should rather
> become part of the general Mk/bsd.port.mk?
I think so. My patch was intended to handle only different GCC versions, I made
it for my personal use :-)
Mark's patch on the other hand does a job of supporting different compilers too.
> To me it looks more like the latter, Mk/bsd.port.mk, but if not for
> some reason, please add a comment to the top of the file Mk/bsd.gcc.mk
> and commit this part.
No, no, thank you :-)
--
Andriy Gapon
More information about the freebsd-ports
mailing list