optionsng and tinderbox?

[Matthew Seaman]

On 23/06/2012 09:18, Baptiste Daroussin wrote:
> Well the priority ordering the logical was to give the end word to the last user
> action.
> 
> It goes from global to specific
> 
> 1/ the global options (infrastructures) are applied
> 2/ the maintainer option (ports are applied)
> 3/ the user global options are applied (OPTIONS_{,UN}SET)
> 4/ the user ports options are applied (${UNIQUENAME}_{,UN}SET)
> 5/ the dialog (make config) options are applied
> 
> If that it looks not good to anyone, please comment (we can still change it) and
> please provide arguments.

It's the ordering of 4 and 5 that confuses me.

If you've got ${UNIQUENAME}_{,UN}SET in /etc/make.conf and then you run
'make config' you'ld expect the choices you make in the dialogue to be
the final word. (ie. 5 overrides 4, as currently) (Would you expect the
make.conf setting to affect what is shown in the dialog initially?
Seems logical)

On the other hand, if you run 'make foo_SET=yes all' on a command line,
you'ld expect the command line to override anything saved in an options
file (ie 4 overrides 5).

I don't think you can have both of those behaviours in any reasonable
way.  If forced to choose, I'd prefer to have the capability to override
a config setting as a one-off on the command line.

Also given that in normal usage, selections would always be made in the
options dialogue when the port was compiled, so they would always
override any ${UNIQUENAME}_{,UN}SET setting in /etc/make.conf or from
the command line.  Which implies ${UNIQUENAME}_{,UN}SET only has any
utility when the options dialogues are not used, such as in tinderbox or
other port building systems.  Swapping 4 and 5 would make the behaviour
more consistent for all usage patterns.

	Cheers,

	Matthew

-- 
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 267 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20120623/ba486285/signature.pgp