Firefox and firefox-remote options issues

[Kevin Oberman]

On Sat, Jun 9, 2012 at 11:54 AM, Matthew Seaman
<m.seaman at infracaninophile.co.uk> wrote:
> On 09/06/2012 17:02, Kevin Oberman wrote:
>> Wow! Not what I expected to find!
>>
>> Yes, /var/db/ports/firefox/options is there, but
>> /var/db/ports/firefox-remote/options is not. And, when I look at
>> /var/db/ports/firefox/options, it actually contains the options for
>> firefox-remote!
>>
>> If I go into www/firefox and make config,
>> /var/db/ports/firefox-remote/options contains the right options. Ouch.
>>
>> I'll need to re-build firefox-remote later, but at least I now expect
>> firefox to build as I want it to. Something in parsing the port name
>> seems to have been broken.
>
> That looks to be an accident.  Both those ports share the same options file:
>
> % cd /usr/ports
> % make -C www/firefox -V OPTIONSFILE
> /var/db/ports/firefox/options
> % make -C www/firefox-remote -V OPTIONSFILE
> /var/db/ports/firefox/options
>
> Ultimately this is because both those ports have PORTNAME=firefox, which
> means both of them end up with the same UNIQUENAME, which is clearly a
> bit contrary to the intent of that variable.
>
> This would have been the case even before OPTIONSng -- the location
> where options would be stored hasn't changed.  However, firefox-remote
> doesn't set any options of its own, so previously it wouldn't have used
> its options file at all.  One of the effects of OPTIONSng is that every
> port technically now uses options so would now use an options file.  So
> collisions like this are going to show up.
>
> However, not all ports sharing OPTIONSFILEs are accidental.  For
> instance Postgresql ports all use a shared file quite deliberately.
>
> Attached is a list of all the ports with a non-unique UNIQUENAME setting.

Ahh. If I'd had some time, I suspect I would have spotted it. I am
amazed that it has never bitten me in the past as I have had this port
installed for over a decade. Of course, it would not have shown up
using portupgrade, but portmaster does show it as it queries for
options for all ports to be built BEFORE it starts building. I guess I
never noticed that firefox-remote always asks for options but was
seldom rebuilt while firefox is built frequently, but I guess I've
never done a system where both were installed by portmaster in a
single operation.

Thanks.  I'll drop the maintainer of firefox-remote a note open a PR on it.
R. Kevin Oberman - Network Engineer
rkoberman at gmail.com