'make extract' downloads already downloaded file

[Fernando Apesteguía]

On Tue, Jun 5, 2012 at 7:12 PM, Fernando Apesteguía
<fernando.apesteguia at gmail.com> wrote:
> Hi all,
>
> I'm having a problem with a port I am currently maintaining. This is
> the log from pointyhat:
>
> erwin at freefall:cad/openvsp> make fetch
> ===>  License check disabled, port has not defined LICENSE
> /usr/bin/fetch -o /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_2.0_Community
> /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz  100% of 2808 kB 1271 kBps
> erwin at freefall:cad/openvsp> make extract
> ===>  License check disabled, port has not defined LICENSE
> /usr/bin/fetch -o /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_2.0_Community
> /home/erwin/tmp/OpenVSP_2.0_Community.tar.gz  100% of 2808 kB 1208 kBps
> ===>  Extracting for openvsp-2.0_1
> => SHA256 Checksum OK for OpenVSP_2.0_Community.tar.gz.
> erwin at freefall:cad/openvsp>
>
> This[1] is the current Makefile
>
> According to Erwin there's something wrong with the redefinition of
> DISTNAME and do-fetch that confuses the infrastructure. I tried to do
> the same thing I do in another port I maintain, math/dynare[2] which
> doesn't suffer this problem. This is the Makefile I'm working on:

Correction: math/dynare suffers the same problem.

I finally have a fix for this (check for the presence of DISTNAME in DISTDIR
before trying to download the file).

Thanks.

>
>
> # Port makefile for:    openvsp
> # Date created:         Apr 10 2012
> # Whom:                 Fernando Apesteguia <fernando.apesteguia at gmail.com>
> #
> # $FreeBSD$
>
> PORTNAME=       openvsp
> PORTVERSION=    2.0
> CATEGORIES=     cad
> MASTER_SITES=
> https://nodeload.github.com/OpenVSP/OpenVSP/tarball/OpenVSP_${PORTVERSION}_Community
>
> MAINTAINER=     fernando.apesteguia at gmail.com
> COMMENT=        Create a 3D model of an aircraft defined by
> engineering parameters
>
> BUILD_DEPENDS=  ${LOCALBASE}/lib/libopenNURBS.a:${PORTSDIR}/graphics/opennurbs
>
> LIB_DEPENDS+=   fltk:${PORTSDIR}/x11-toolkits/fltk
> LIB_DEPENDS+=   xml2:${PORTSDIR}/textproc/libxml2
> LIB_DEPENDS+=   jpeg:${PORTSDIR}/graphics/jpeg
> LIB_DEPENDS+=   png:${PORTSDIR}/graphics/png
> LIB_DEPENDS+=   Xinerama:${PORTSDIR}/x11/libXinerama
> LIB_DEPENDS+=   Xft:${PORTSDIR}/x11-fonts/libXft
>
> WRKSRC=         ${WRKDIR}/OpenVSP-OpenVSP-574d7c3/src
>
> USE_CMAKE=      yes
> USE_DOS2UNIX=   yes
>
> EXAMPLESDIR=    ${PREFIX}/share/examples/openvsp
>
> do-fetch:
>        fetch -o ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX} ${MASTER_SITES}
>
> do-install:
>        @${INSTALL_PROGRAM} ${WRKSRC}/vsp/vsp ${PREFIX}/bin
>        @${MKDIR} ${EXAMPLESDIR}
> .for i in airfoil cabin fonts fuselage models setup textures
>        @${MKDIR} ${EXAMPLESDIR}/${i}
>        @${INSTALL_DATA} ${WRKSRC}/../examples/${i}/* ${EXAMPLESDIR}/${i}
> .endfor
>
> .include <bsd.port.mk>
>
> Still, after a 'make checksum', invoking a 'make extract' causes the
> tarball to be downloaded again. I checked and the file exists in
> /usr/ports/distfiles
>
> Any ideas of what the problem is?
>
> Thanks in advance.
>
>
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/cad/openvsp/Makefile?rev=1.2;content-type=text%2Fplain
> [2] http://www.freebsd.org/cgi/cvsweb.cgi/ports/math/dynare/Makefile?rev=1.5;content-type=text%2Fplain