Preferred way of applying OSVERSION-dependend patches
Chris Rees
utisoft at gmail.com
Sun Apr 1 20:58:00 UTC 2012
On 1 Apr 2012 21:34, "RW" <rwmaillists at googlemail.com> wrote:
>
> On Sun, 01 Apr 2012 14:02:15 +0400
> Ruslan Mahmatkhanov wrote:
>
> >
> > Good day!
> >
> > What is a preferred way of doing subj?
> >
> > 1. Add an extra-patch-* to files/ subdirectory and apply it depending
> > of checks in Makefile (.if ${OSVERSION}).
> > 2. Add an patch-* to files subdirectory that applies unconditionally
> > and that checking for __FreeBSD_version in app code itself.
> >
> > The second one will guarantee that the patch still applies cleanly on
> > port versions update,
>
> It also works correctly for package files.
>
Not really-- #if directives are evaluated at compile time.
FWIW, I'm not too bothered about it, but #1 strikes me as better practice,
though perhaps GNU-ish;.akin to using if instead of #if.
Chris
Chris
More information about the freebsd-ports
mailing list