USERS/GROUPS in bsd.port.mk [was: FreeBSD Port: postfix-2.8.4, 1]

[Sahil Tandon]

On Sep 8, 2011, at 7:35 AM, Miroslav Lachman <000.fbsd at quip.cz> wrote:

> Miroslav Lachman wrote:
>> Sahil Tandon wrote:
>>> On Tue, 2011-08-02 at 00:04:14 +0200, olli hauer wrote:
>>> 
>>>> No, you don't hit the limitation. It seems you really found a bug in
>>>> the Framework!
>>>> 
>>>> From the Framework code in bsd.port.mk existing groups should honored.
>>> 
>>> Along those lines, what about using groupmod instead of usermod?
>>> Perhaps due to my ignorance, it seems more straightforward and does not
>>> require much sed-fu; I've attached a (probably incomplete) patch to
>>> illustrate my thinking. I understand what I am suggesting could
>>> introduce other problems, so please do not construe it as an as-is
>>> suggestion, but rather something to stoke discussion.
>> 
>> I tested your patch and it works for me.
>> 
>> # pkg_version -vIL = | grep postfix
>> postfix-2.7.2,1 < needs updating (index has 2.8.4,1)
>> 
>> # id postfix
>> uid=125(postfix) gid=125(postfix)
>> groups=125(postfix),6(mail),3125(maildirs)
>> 
>> # patch < ~/bsd.port.mk.diff
>> 
>> # portmaster postfix-2.7.2,1
>> 
>> ===>>> The following actions were performed:
>> Upgrade of mysql-client-5.1.53 to mysql-client-5.1.58
>> Upgrade of libtool-2.2.10 to libtool-2.4
>> Upgrade of cyrus-sasl-2.1.23_1 to cyrus-sasl-2.1.23_3
>> Upgrade of postfix-2.7.2,1 to postfix-2.8.4,1
>> 
>> # id postfix
>> uid=125(postfix) gid=125(postfix)
>> groups=125(postfix),6(mail),3125(maildirs)
>> 
>> It was tested on really old testing system...
>> 
>> Thank you for your time and working solution.
> 
> Will the fix be committed to the ports tree? I upgraded Postfix on another machines yesterday and get the same error as reported month ago - upgrade removed postfix from manualy created group.
> 
> Should I send PR for this?

I am very sorry to hear that.  I already filed a PR after you sent your report to this mailing list, and followed up with portmgr@ earlier this week.  I believe they are doing an -exp run before committing the change.  I will ping them again if there is no progress in the next few days.  Sorry again for the inconvenience.