Port submit status (Port/157426).

[Chris Rees]

On 24 July 2011 12:04, Joris Vandalon <joris at vandalon.nl> wrote:
> Hi,
>
> I submitted a freebsd port (157426) the 30th of may.
> Now I know I should be patient but I was wondering if there is something is wrong with this port since previous ports where always accepted within a month.
>

Hi Joris,

I've replied to the PR, and scanning over it again I've just noticed
that you've patched the distribution's Makefile to make an install
target.

Normally we use something like (in the port's Makefile):

do-install:
<TAB>${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin/
<TAB>${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MAN1PREFIX}/man/man1/

Oops, in patch-config.mk:

UNRAR_LIB=/usr/lcoal/lib

Probably better (rather than hardcoding /usr/local) to use
%%LOCALBASE%% in the patch for the UNRAR_LIB and FUSE_SRC, and
%%PREFIX%% for DESTDIR and then:

post-patch:
<TAB>${REINPLACE_CMD} -e 's,%%LOCALBASE%%,${LOCALBASE},' \
<TAB>       -e 's,%%PREFIX%%,${LOCALBASE},' \
<TAB>       ${WRKSRC}/config.mk

If you fix these issues I'll take it.

Chris