[RFC] A trivial change for DESKTOP_ENTRIES

Doug Barton dougb at FreeBSD.org
Wed Jul 13 04:30:54 UTC 2011


On 07/12/2011 21:29, Stephen Montgomery-Smith wrote:
> On 07/12/2011 11:17 PM, Doug Barton wrote:
>> On 07/12/2011 21:08, Stephen Montgomery-Smith wrote:
>>> Thinking more about it, it seems to me that instead of silently deleting
>>> the disallowed characters in the filename, that the port should declare
>>> itself broken if there are disallowed characters.  That way, this
>>> particular error would have been caught far more easily.
>>
>> I was thinking along similar lines. My concern would be that if the
>> change to allow - and _ is done silently that it will break plists.
>>
>>
> 
> I don't see how it can break plists - a few lines later (around line
> 6440), bsd.port.mk dynamically generates the entries for plist from
> $filename.

Ah, never mind then. :)



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/



More information about the freebsd-ports mailing list