PostgreSQL 9.0.4 %%PG_USER%% not changed

[Chris Rees]

On 15 August 2011 09:04, Chris Rees <utisoft at gmail.com> wrote:
> This might be my fault, I'll invest8gate. Sorry.
>
> On 14 Aug 2011 21:02, "Jason Helfman" <jhelfman at e-e.com> wrote:
>>> [ mantainer added to Cc: ]
>>>
>>> On Sun, 2011-08-14 at 18:04:55 +0500, rihad wrote:
>>>
>>>> Hi, I have installed the latest
>>>> postgresql-server-9.0.4_2
>>>> postgresql-client-9.0.4_1
>>>>
>>>> In several places, namely in /usr/local/etc/rc.d/postgresql:
>>>> postgresql_user=${postgresql_user:-"%%PG_USER%%"}
>>>>
>>>> and throughout all of /usr/local/etc/periodic/daily/502.pgsql
>>>>
>>>> %%PG_USER%% is left as is, which should have presumably been changed
>>>> to pgsql by the installation script.
>>>> What gives?
>>>
>>> Based on a quick glance, it seems that the expansion does occur because
>>> PG_USER is not set in SUB_LIST.
>>
>> This commit also changed the ability to configure a different user, as the
>> pgsql isn't part of the base operating system installation, and having a
>> configurable user, group and id, allowed users to change what user was
>> running postgresql as. This is now not the case. This patch was used in
>> addressing this: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153668
>>
>> The aforementioned PR was submitted as a fix for this PR (
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/113707 ) which addressed
>> the issue in a non-standard way.
>>
>> I really don't understand why this was done, as this really broke the
>> essence of why this port was changed to support "any" user one would want
>> to run the postgresql server as, and now this functionality is gone.
>>
>> It would be great to see this change back in place so one may run the
>> server as any user they choose, and not just "pgsql," especially since
>> this user isn't in the base system.
>>
>> -jgh

OK, I've reverted the problem commit (s) [1]. I'm going to take a look
at how to do this properly -- we really do need to use the code in
bsd.port.mk for creating users rather than using pkg-install files.

Rihad, please try csupping / portsnap and check that in
postgresql90-server has the line:

$FreeBSD: ports/databases/postgresql90-server/Makefile,v 1.222
2011/08/15 14:52:31 crees Exp $

Then reinstall and your problem will be gone.

Sorry for the disruption.

Chris

[1] http://lists.freebsd.org/pipermail/cvs-ports/2011-August/223423.html


-- 
Chris Rees          | FreeBSD Developer
crees at FreeBSD.org   | http://people.freebsd.org/~crees