sysutils/xfce4-netload-plugin - why is it marked as broken on 8?

[Alexey Shuvaev]

On Wed, Feb 10, 2010 at 10:33:35PM +0100, Torfinn Ingolfsen wrote:
> Hello,
> 
> On Fri, Jan 15, 2010 at 7:41 PM, Greg Larkin <glarkin at freebsd.org> wrote:
> 
> > This commit log refers to the fact that the value of __FreeBSD_version
> > was bumped to 800045 due to the removal of the if_ppp(4) driver.  You
> > can find all of the historical values of that variable here:
> > http://www.freebsd.org/doc/en/books/porters-handbook/freebsd-versions.html
> >
> > In this case, the port Makefile should be patched like so:
> >
> > - --- Makefile.orig       2010-01-15 13:37:50.374330422 -0500
> > +++ Makefile    2010-01-15 13:38:04.101133409 -0500
> > @@ -24,7 +24,7 @@
> >
> >  .include <bsd.port.pre.mk>
> >
> > - -.if ${OSVERSION} >= 800000
> > +.if ${OSVERSION} >= 800045
> >
> 
> Well, that value doesn't work anymore. Here's the rub:
> root at kg-v2# uname -a
> FreeBSD kg-v2.kg4.no 8.0-STABLE FreeBSD 8.0-STABLE #1: Wed Jan  6 21:21:40
> CET 2010     root at kg-v2.kg4.no:/usr/obj/usr/src/sys/GENERIC  amd64
> root at kg-v2# pwd
> /usr/ports/sysutils/xfce4-netload-plugin
> root at kg-v2# make
> ===>  xfce4-netload-plugin-0.4.0_10 is marked as broken: does not compile:
> error: net/if_ppp.h: No such file or directory.
> *** Error code 1
> 
> Stop in /usr/ports/sysutils/xfce4-netload-plugin.
> 
> 
> According to param.h, the value is now 800108. if_ppp.h is still present,
> and the port compiles fine if I comment out the three lines reagarding the
> BROKEN meaasge.
> 
You have stale files in your system. From /usr/src/ObsoleteFiles.inc:

# 20090406: usb_sw_transfer.h removed
OLD_FILES+=usr/include/dev/usb/usb_sw_transfer.h
# 20090405: removal of if_ppp(4) and if_sl(4)
OLD_FILES+=sbin/slattach rescue/slattach
OLD_FILES+=sbin/startslip rescue/startslip
OLD_FILES+=usr/include/net/if_ppp.h
OLD_FILES+=usr/include/net/if_pppvar.h
OLD_FILES+=usr/include/net/if_slvar.h
OLD_FILES+=usr/include/net/ppp_comp.h
OLD_FILES+=usr/include/net/slip.h
OLD_FILES+=usr/sbin/sliplogin

You should do 'make delete-old' and 'make delete-old-libs' during upgades.

> > A better fix might be to port the code from using if_ppp(4) to the
> > replacement ppp(8), as noted in the commit log.
> 
> Probably. I don't know how to do that. Sorry.
>