MAKE_JOBS_UNSAFE (some more ports)

[Pav Lucistnik]

David Naylor píše v po 25. 05. 2009 v 10:11 +0200:

> > > > > > > This part looks OK, I wonder if there's any reason t ain't like
> > > > > > > this now; Pav?
> > > > > > > -.if defined(MAKE_JOBS_NUMBER)
> > > > > > > +MAKE_JOBS_NUMBER?=	`${SYSCTL} -n kern.smp.cpus`
> > > > > > >  _MAKE_JOBS=		-j${MAKE_JOBS_NUMBER}
> > > > > > > -.else
> > > > > > > -_MAKE_JOBS=		-j`${SYSCTL} -n kern.smp.cpus`
> > > > > > > -.endif
> > > > > >
> > > > > > Wouldn't that mean an evaluation of the backtick command in every
> > > > > > make(1) invocation? That would be highly undesirable.
> > >
> > > I don't believe that is the case.
> > >
> > > Here is what I get with the patch applied (MAKE_JOBS_NUMBER not defined):
> > > /usr/ports/editors/openoffice.org-3# make -V MAKE_JOBS_NUMBER -V
> > > _MAKE_JOBS `/sbin/sysctl -n kern.smp.cpus`
> > > -j`/sbin/sysctl -n kern.smp.cpus`
> > >
> > > Wouldn't this indicate that the backtick command is not being evaluated?
> >
> > Seems correct. But explain again, why you need this change? 
> 
> Not all ports use make but are concurrent capable and require different 
> arguments to be passed which is why I needed to expose MAKE_JOBS_NUMBER 
> (since it is just a number) and why _MAKE_JOBS was not an option.  

Ok, how about doing a dirty hack and using ${_MAKE_JOBS:C/-j//} ?
Then we wouldn't have to modify bsd.port.mk ..

-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>

> Why do we need a film of "Lord of the Rings" when we have the book?
Because watching a cg enhanced Legolas fire a flaming arrow
into the heart of a warg is cool?
    - asdf at asdf.com in rec.games.roguelike.angband
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090525/dbe443ba/attachment.pgp