MAKE_JOBS_UNSAFE (some more ports)

[Ion-Mihai Tetcu]

On Sun, 24 May 2009 16:10:23 +0200
Pav Lucistnik <pav at FreeBSD.org> wrote:

> Ion-Mihai Tetcu píše v so 23. 05. 2009 v 13:51 +0300:
> 
> > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of
> > > > cores
> > 
> > This part looks OK, I wonder if there's any reason t ain't like this
> > now; Pav?
> > -.if defined(MAKE_JOBS_NUMBER)
> > +MAKE_JOBS_NUMBER?=	`${SYSCTL} -n kern.smp.cpus`
> >  _MAKE_JOBS=		-j${MAKE_JOBS_NUMBER}
> > -.else
> > -_MAKE_JOBS=		-j`${SYSCTL} -n kern.smp.cpus`
> > -.endif
> 
> Wouldn't that mean an evaluation of the backtick command in every
> make(1) invocation? That would be highly undesirable.

Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no?
Am I missing some make magic here?

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090524/7c31af90/signature.pgp