MAKE_JOBS_UNSAFE (some more ports)

[David Naylor]

On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote:
> Hi I tested it yesterday,
>
> 1.
> I need
>
> > MAKE_JOBS_SAFE=        yes
>
> in the Makefile.

Yes, you would need that.  I believe that will be default.  

> 2. with above patch, ooo2 doesn't launch parallele jobs.

I spotted that problem after submitting the patch, if you explicitly set 
MAKE_JOBS_NUMBER to something it will work. 

The problem is that ooo2 does (in effect):
.if (${MAKE_JOBS_NUMBER} > 1)
# Stuff
.else
# Other stuff
.endif
and that doesn't work as expected with MAKE_JOBS_NUMBER=`sysctl kern.smp.cpus` 
as the command is not resolved.  

> 3. ooo3, 3-rc, 3-devel are okay with patch 1.

Good to hear.  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part.
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090524/ed932254/attachment.pgp