HEADS UP multi processor compilations for everyone

[Pav Lucistnik]

Dmitry Marakasov píše v pá 27. 03. 2009 v 15:48 +0300:
> * Pav Lucistnik (pav at FreeBSD.org) wrote:
> 
> > > second
> > > also improves MAKE_JOBS_* handling, shortening it a bit and exposing
> > > MAKE_JOBS_NUMBER to the ports, so it can be used for other build systems
> > > without having to parse out -j from _MAKE_JOBS (and defaults to 1 if
> > > jobs support is disabled).
> > 
> > This one I cannot accept, because it adds back != call I made a big
> > effort to avoid. We can't have one != call per port during building
> > INDEX.
> 
> Understood. I still think it'd be nice to expose number of jobs as a
> plain number to the ports.

If you figure it out without != call, let me know.

> > > Also, [ x != x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsafe,
> > > and inconsistent to IGNORE/BROKEN/... vars, in which we don't use
> > > quotes.
> > 
> > It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the
> > parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW?
> > Because they are present in do-configure target too - should they be
> > removed there too?
> 
> I just didn't like them :) 

Good enough reason for me :)

> Are they really needed around single command?

No idea.

-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>
On real UNIX, /usr/bin/more prints -More-.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090329/a29ba1ff/attachment.pgp