Removed port OPTIONS linger in /var/db/ports/.../options

[Nick Withers]

Hello all!

I was surprised to see, when trying to update lang/ruby18 today, that
the to-be-installed package would be named "ruby
+nopthreads-1.8.7.160_3,1", rather than the expected
"ruby-1.8.7.160_3,1".

Checked out the port's Makefile, and indeed this name is now set when
"WITHOUT_PTHREADS" is defined. Righto, no worries.

I hadn't defined WITHOUT_PTHREADS though... Or at least, didn't think I
had! "make config" for lang/ruby18 didn't even show such an option.

"/var/db/ports/ruby/options", however, did, left over from a while back:
____

# This file is auto-generated by 'make config'.
# No user-servicable parts inside!
# Options for ruby-1.8.7.72_1,1
_OPTIONS_READ=ruby-1.8.7.72_1,1
WITHOUT_PTHREADS=true
WITHOUT_ONIGURUMA=true
WITHOUT_GCPATCH=true
WITH_IPV6=true
WITHOUT_RDOC=true
WITHOUT_DEBUG=true
____

I must admit, I thought that when options were added or removed, the
OPTIONS dialogue was redisplayed automatically, but it seems this is
only when options are added (consistent with what seems to be implied in
http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html).

So, to get to my point: Would it be a good thing for unknown options in
ports' options files to be removed automatically during the make (or
somewhere else?)? Would it be better to redisplay ports' OPTIONS
dialogues both on addition and on removal of OPTIONS? Should I just shut
up? I don't really want to clear all ports options before each
portmaster / portupgrade run, but for now I'm inclined to to reduce the
risks of having weird and wonderful options set.

In case it matters, this is what I ended up with in
"/var/db/ports/ruby/options" after a "make config", not changing options
but selecting "OK" (note the "ruby+nopthreads" bits):
____

# This file is auto-generated by 'make config'.
# No user-servicable parts inside!
# Options for ruby+nopthreads-1.8.7.160_3,1
_OPTIONS_READ=ruby+nopthreads-1.8.7.160_3,1
WITHOUT_ONIGURUMA=true
WITH_IPV6=true
WITHOUT_RDOC=true
WITHOUT_DEBUG=true
____
-- 
Nick Withers
email: nick at nickwithers.com
Web: http://www.nickwithers.com
Mobile: +61 414 397 446