[patch] pkg_delete(1) speedup

[Doug Barton]

Roman Divacky wrote:
> On Wed, Mar 26, 2008 at 05:18:29PM +0100, Pav Lucistnik wrote:
>> You might have noticed a thread on the mailing list called "ports system
>> woes". The submitter pointed out an inefficiency in pkg_delete routine,
>> that parses the whole /var/db/pkg over and over again for every
>> dependency of a package being removed.
>>
>> Attached is a patch by rdivacky that implements the idea of looking up
>> all the values in a single pass over /var/db/pkg content.
> 
> I hacked a slightly better patch that coveres a part of pkg_add too..
> 
> please review/test on:
> 
> 	www.vlakno.cz/~rdivacky/pkg_tools.patch
> 
> comments, benchmarks more than welcome!

A) this is massively cool stuff, thanks for taking this on. :)
B) you should probably do two versions of the patch, one with 
style(9)-only changes, and one without. The former makes it much easier 
to review the actual changes, and would speed your path to getting it in 
the tree.

Doug

-- 

     This .signature sanitized for your protection