Problems with startup scripts

[Paul Schmehl]

To reply - figure it out
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=sha1;
 protocol="application/pkcs7-signature";
 boundary="==========628ED6B4E6FA03BA9DD4=========="

--==========628ED6B4E6FA03BA9DD4==========
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Recently someone more experienced than I stated that I should change the=20
construction of my startup scripts to use the following construction:

command_args=3D"${port_conf} ${port_flags}"

I dutifully changed several of my ports' startup scripts to use that=20
construction.  Now one of my scripts has been reported as failing.  The=20
problem is that it's trying to run $rc_flags twice.  I've been scratching=20
my head for two days now, running sh-x startup_script to try and figure=20
out what was wrong with my script.

Since I'm not that familiar with rc_subr, I ran some of my other ports=20
that used the same construction (but I've had reports of failures) through =

the same process, saved the results to text files and then carefully=20
examined them.

Imagine my surprise when I discovered that *all* of my startup scripts=20
were running double flags!

So, I looked at /etc/rc.subr, and lo and behold:
Line 670 of /etc/rc.subr has "$command $rc_flags $command_args"

So, the question is, is this an error in rc_subr?  Or was I misinformed=20
about the use of cammand_args?  If the former, do I submit a PR?  If the=20
latter, I have a lot of work to do.  {{{sigh}}}

I suspect it's the latter, which doesn't make me real happy, but I guess=20
I'll chalk it up to a learning experience.

Paul Schmehl
If it isn't already obvious,
my opinions are my own and not
those of my employer.

--==========628ED6B4E6FA03BA9DD4==========
Content-Type: application/pkcs7-signature
Content-Transfer-Encoding: base64

MIIO7gYJKoZIhvcNAQcCoIIO3zCCDtsCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3
DQEHAaCCDFwwggV1MIIE3qADAgECAhAxxWbtEfZaUjaDZLSj5PqQMA0GCSqGSIb3
DQEBBQUAMIHqMScwJQYDVQQKEx5UaGUgVW5pdmVyc2l0eSBvZiBUZXhhcyBTeXN0
ZW0xHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOzA5BgNVBAsTMlRl
cm1zIG9mIHVzZSBhdCBodHRwczovL3d3dy52ZXJpc2lnbi5jb20vcnBhIChjKTk5
MTIwMAYDVQQLEylDbGFzcyAyIENBIC0gT25TaXRlIEluZGl2aWR1YWwgU3Vic2Ny
aWJlcjEtMCsGA1UEAxMkVGhlIFVuaXZlcnNpdHkgb2YgVGV4YXMgYXQgRGFsbGFz
IENBMB4XDTA3MTAwODAwMDAwMFoXDTA4MTAwNzIzNTk1OVowgfYxJzAlBgNVBAoU
HlRoZSBVbml2ZXJzaXR5IG9mIFRleGFzIFN5c3RlbTEtMCsGA1UECxQkVGhlIFVu
aXZlcnNpdHkgb2YgVGV4YXMgYXQgRGFsbGFzIENBMUYwRAYDVQQLEz13d3cudmVy
aXNpZ24uY29tL3JlcG9zaXRvcnkvQ1BTIEluY29ycC4gYnkgUmVmLixMSUFCLkxU
RChjKTk5MRgwFgYDVQQLFA9NYWlsIFN0b3AgLSBVVEQxFzAVBgNVBAMTDlBhdWwg
TCBTY2htZWhsMSEwHwYJKoZIhvcNAQkBFhJwYXVsc0B1dGRhbGxhcy5lZHUwgZ8w
DQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBALVzB0IIkR8iraIfDdWB1EZ1/Gbg7Rm6
yQuLIUlemm3awYksmEOPKqL2YQxGhCvbVq/IYcoGuT+WEaxuwN86uIkP/kOReQDO
tMHyy/sA1XaxpoS0ezjwHasNH1f63yZbFkQiwSuWQOvdXlLqtJ9E2UrzbqVWdqlr
FzzeZwP5DipHAgMBAAGjggIMMIICCDAJBgNVHRMEAjAAMB0GA1UdEQQWMBSBEnBh
dWxzQHV0ZGFsbGFzLmVkdTCCASQGA1UdIASCARswggEXMIIBEwYLYIZIAYb4RQEH
AQYwggECMCsGCCsGAQUFBwIBFh9odHRwczovL3d3dy52ZXJpc2lnbi5jb20vcnBh
LWtyMIHSBggrBgEFBQcCAjCBxRqBwk5PVElDRTogUHJpdmF0ZSBrZXkgbWF5IGJl
IHJlY292ZXJlZCBieSBWZXJpU2lnbidzIGN1c3RvbWVyIHdobyBtYXkgYmUgYWJs
ZSB0byBkZWNyeXB0IG1lc3NhZ2VzIHlvdSBzZW5kIHRvIGNlcnRpZmljYXRlIGhv
bGRlci4gIFVzZSBpcyBzdWJqZWN0IHRvIHRlcm1zIGF0IGh0dHBzOi8vd3d3LnZl
cmlzaWduLmNvbS9ycGEta3IgKGMpOTkuMBEGCWCGSAGG+EIBAQQEAwIHgDB1BgNV
HR8EbjBsMGqgaKBmhmRodHRwOi8vb25zaXRlY3JsLnZlcmlzaWduLmNvbS9UaGVV
bml2ZXJzaXR5b2ZUZXhhc1N5c3RlbVRoZVVuaXZlcnNpdHlvZlRleGFzYXREYWxs
YXNDQS9MYXRlc3RDUkwuY3JsMAsGA1UdDwQEAwIFIDAdBgNVHSUEFjAUBggrBgEF
BQcDBAYIKwYBBQUHAwIwDQYJKoZIhvcNAQEFBQADgYEAT6Pe5vS1wCy6fAnTHJT5
GkqxV3ro1CmSiwCkC84vI4TUbxsbVAYuvafQw1H137mxYACJ73UwYnI8WhDKPYlR
y1QEnq7uwanNPtXtWTSxvOXtb2w4rGiXX9fkLfslmkX8jNgC7uMx8H39VBe90ob6
rURohgP1DsYwpJZF9SgoCeIwggPYMIIDQaADAgECAhBB7B89pxQHlsT21Qzd0Q9l
MA0GCSqGSIb3DQEBBQUAMIHBMQswCQYDVQQGEwJVUzEXMBUGA1UEChMOVmVyaVNp
Z24sIEluYy4xPDA6BgNVBAsTM0NsYXNzIDIgUHVibGljIFByaW1hcnkgQ2VydGlm
aWNhdGlvbiBBdXRob3JpdHkgLSBHMjE6MDgGA1UECxMxKGMpIDE5OTggVmVyaVNp
Z24sIEluYy4gLSBGb3IgYXV0aG9yaXplZCB1c2Ugb25seTEfMB0GA1UECxMWVmVy
aVNpZ24gVHJ1c3QgTmV0d29yazAeFw05OTAzMzEwMDAwMDBaFw0wOTAzMzAyMzU5
NTlaMIHqMScwJQYDVQQKEx5UaGUgVW5pdmVyc2l0eSBvZiBUZXhhcyBTeXN0ZW0x
HzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOzA5BgNVBAsTMlRlcm1z
IG9mIHVzZSBhdCBodHRwczovL3d3dy52ZXJpc2lnbi5jb20vcnBhIChjKTk5MTIw
MAYDVQQLEylDbGFzcyAyIENBIC0gT25TaXRlIEluZGl2aWR1YWwgU3Vic2NyaWJl
cjEtMCsGA1UEAxMkVGhlIFVuaXZlcnNpdHkgb2YgVGV4YXMgYXQgRGFsbGFzIENB
MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC/6u+H6x4KwQD5IhHB0cHM23ra
vjbScGAwYOUZ4FMvNfTJqCkF1t49nfMGmmR9vtGHVHib/6J48fuHq8P8h0zCSUEN
4cDSpdf8fv9CUU508wHVaHOlXQQx+OYpJWOoI5pEaoGLD7A58e/bRljDurjPS/N6
waJJlYMjQ7qbGo8yhQIDAQABo4GlMIGiMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQD
ExFQcml2YXRlTGFiZWwxLTE0MDARBglghkgBhvhCAQEEBAMCAQYwRAYDVR0gBD0w
OzA5BgtghkgBhvhFAQcBATAqMCgGCCsGAQUFBwIBFhxodHRwczovL3d3dy52ZXJp
c2lnbi5jb20vUlBBMA8GA1UdEwQIMAYBAf8CAQAwCwYDVR0PBAQDAgEGMA0GCSqG
SIb3DQEBBQUAA4GBAFMJtdyytonRIFCDyTh53MgIskm/uFODb4rMsuR6fPyj6A9f
YV5flwSVElrSlQEi8bzt8VS2VKZUGKGdVLwGaQTHAiE3ooI5iKesoJ/ogxldkkg5
GlmCJCBDvIaVEtyDdOHm4xO+aqSHADExIwclm6+6LFGRDlmmoxeI0rTOVBccMIID
AzCCAmwCEQC5L2DMiJ+hekYJuFtwbIqvMA0GCSqGSIb3DQEBBQUAMIHBMQswCQYD
VQQGEwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xPDA6BgNVBAsTM0NsYXNz
IDIgUHVibGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMjE6
MDgGA1UECxMxKGMpIDE5OTggVmVyaVNpZ24sIEluYy4gLSBGb3IgYXV0aG9yaXpl
ZCB1c2Ugb25seTEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazAeFw05
ODA1MTgwMDAwMDBaFw0yODA4MDEyMzU5NTlaMIHBMQswCQYDVQQGEwJVUzEXMBUG
A1UEChMOVmVyaVNpZ24sIEluYy4xPDA6BgNVBAsTM0NsYXNzIDIgUHVibGljIFBy
aW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMjE6MDgGA1UECxMxKGMp
IDE5OTggVmVyaVNpZ24sIEluYy4gLSBGb3IgYXV0aG9yaXplZCB1c2Ugb25seTEf
MB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazCBnzANBgkqhkiG9w0BAQEF
AAOBjQAwgYkCgYEAp4gBIXQs5xoD8JjhlzwPIQjxnNuX6Zr8wgQGE75fUsjMHiwS
Viy4AWkszJkfrbCWrnkE8hM5wXuYuggs6MKEEyyqaekJ9MepAqRCwiNPStjwDqL7
MWzJ5m+ZJwf15vRMeJ5t60aG+rmGyVTyssSv1EYcWskVMP8NbPUtDm3Of3cCAwEA
ATANBgkqhkiG9w0BAQUFAAOBgQByLvl/0fFx+8Se9sVeUYpAmLho+Jscg9jinb3/
7aHmZuovCfTK1+qlK5X2JGCGTUQug6XELaDTrnhpb3LabK4I8GOSN+a7xDAXrXfM
STWqz9iP0b63GJZHc2pUIjRkLbYWm1lbtFFZOrMLFPQS32eg9K0yZF6xRnInjBJ7
xUS0rjGCAlowggJWAgEBMIH/MIHqMScwJQYDVQQKEx5UaGUgVW5pdmVyc2l0eSBv
ZiBUZXhhcyBTeXN0ZW0xHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsx
OzA5BgNVBAsTMlRlcm1zIG9mIHVzZSBhdCBodHRwczovL3d3dy52ZXJpc2lnbi5j
b20vcnBhIChjKTk5MTIwMAYDVQQLEylDbGFzcyAyIENBIC0gT25TaXRlIEluZGl2
aWR1YWwgU3Vic2NyaWJlcjEtMCsGA1UEAxMkVGhlIFVuaXZlcnNpdHkgb2YgVGV4
YXMgYXQgRGFsbGFzIENBAhAxxWbtEfZaUjaDZLSj5PqQMAkGBSsOAwIaBQCggbEw
GAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDgwNjAz
MDMxMzIwWjAjBgkqhkiG9w0BCQQxFgQUg7FnkuEdBd4SvHXJhVPmrKUdCdQwUgYJ
KoZIhvcNAQkPMUUwQzAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZI
hvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAE
gYApB0yKjqilsvztlD5PS2Hize9ItTXSSM4Ib44lCKxfgvLF10izC7SkwY1/4Iwg
DMWR4JxW+6Q8zgBvhSHzwDx5Hv/aFP/VG0QrHedNysnG3Hjl6teP33ISF6fovcgo
+dZRQ1QliNBHDji6Rg4FoKSjtY2T9RB3034f6+ZtXARrEQ==

--==========628ED6B4E6FA03BA9DD4==========--