portupgrade 2.4.6,2 ignores build failure

[Kostik Belousov]

On Thu, Jul 24, 2008 at 03:10:29PM +0300, Kostik Belousov wrote:
> I was updating the policykit port, that failed. It seems that portupgrade
> ignored the build error and tried to process further.
> 
> kit-string.c  -fPIC -DPIC -o .libs/kit-string.o
> kit-string.c:141: error: redefinition of 'strndup'
> kit-string.c:119: error: previous definition of 'strndup' was here
> gmake[3]: *** [kit-string.lo] Ошибка 1
> gmake[3]: Leaving directory `/usr/home/portsworkdir/usr/bsd/ports/sysutils/polic
> ykit/work/PolicyKit-0.9/src/kit'
> gmake[2]: *** [all-recursive] Ошибка 1
> gmake[2]: Leaving directory `/usr/home/portsworkdir/usr/bsd/ports/sysutils/policykit/work/PolicyKit-0.9/src'
> gmake[1]: *** [all-recursive] Ошибка 1
> gmake[1]: Leaving directory `/usr/home/portsworkdir/usr/bsd/ports/sysutils/policykit/work/PolicyKit-0.9'
> gmake: *** [all] Ошибка 2
> *** Error code 2
> 
> Stop in /usr/bsd/ports/sysutils/policykit.
> --->  Backing up the old version
> ^C--->  Upgrading 'xf86-video-intel-2.2.1_1' to 'xf86-video-intel-2.3.2' (x11-drivers/xf86-video-intel)

Even worse. I had specified both policykit and policykit-gnome on the
portupgrade command file. Despite policykit being marked as dependency
for policykit-gnome:

alf% pkg_info -r policykit-gnome-0.8_1 | grep pol
Information for policykit-gnome-0.8_1:
Dependency: policykit-0.9

and policykit failed (at least, I stopped the process by ^C), portupgrade
started the policykit-gnome build. And now, look at the log:

rization.Tpo -c -o polkit_gnome_authorization-polkit-gnome-authorization.o `test -f 'polkit-gnome-authorization.c' || echo './'`polkit-gnome-authorization.c   
^Cgmake[3]: *** Удаляется файл `polkit_gnome_authorization-polkit-gnome-authorization.o'
gmake[3]: *** [polkit_gnome_authorization-polkit-gnome-authorization.o] Interrupt: 2 
gmake[2]: *** [all] Interrupt: 2
gmake[1]: *** [all-recursive] Interrupt: 2
gmake: *** [all] Interrupt: 2
--->  Backing up the old version
--->  Uninstalling the old version
^C   
Interrupted.
--->  Installing the new version via the port with make flags: WANT_OPENLDAP_VER=24 WANT_OPENLDAP_SASL=yes WANT_FAM_SYSTEM=fam WITH_BDB_VER=46 "WITH_GECKO=\"firefox\" WITH_UNIXODBC=yes GNUSTEP_WITH_GCC42=yes EMACS_PORT_NAME=emacs22 DISABLE_VULNERABILITIES=yes NO_IGNORE=yes"
===>  Building for policykit-gnome-0.9
gmake  all-recursive
gmake[1]: Entering directory `/usr/home/portsworkdir/usr/bsd/ports/sysutils/policykit-gnome/work/PolicyKit-gnome-0.9'
Making all in data
gmake[2]: Entering directory `/usr/home/portsworkdir/usr/bsd/ports/sysutils/policykit-gnome/work/PolicyKit-gnome-0.9/data'
Making all in src
^Cgmake[1]: *** [all-recursive] Interrupt: 2
gmake: *** [all] Interrupt: 2
^C--->  Cleaning out obsolete shared libraries

The error results for any failed stage is ignored, and portupgrade blindly
goes forward.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20080724/b634be92/attachment.pgp