ports/124985: [patch] devel/dmucs unbreak on 64bits archs
Pietro Cerutti
gahr at FreeBSD.org
Mon Jul 7 16:35:02 UTC 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
fjoe at FreeBSD.org wrote:
| Synopsis: [patch] devel/dmucs unbreak on 64bits archs
|
| State-Changed-From-To: open->closed
| State-Changed-By: fjoe
| State-Changed-When: Mon Jul 7 16:18:07 UTC 2008
| State-Changed-Why:
| Proper integer type for holding pointers is "long", not "size_t".
I definitely do not agree. Please note that a pointer is not required to
fit into a long, while it is required to fit into a size_t.
Your solution may work as soon as we are concerned only with LP64
machines. As soon as a LLP64 arch steps in, you break things.
| Also, std:map<> containers where sockets are stored should be modified.
|
| Corrected version of the patch committed, thanks!
|
| http://www.freebsd.org/cgi/query-pr.cgi?pr=124985
- --
Pietro Cerutti
gahr at FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEAREKAAYFAkhyRa0ACgkQwMJqmJVx9442QgCg2AjK428zBbh/KxEtrCVPee1q
P80An0H65+EJ79ctx4YpycrwuOkwOttV
=4zPQ
-----END PGP SIGNATURE-----
More information about the freebsd-ports
mailing list