sysutils/cfengine: invalid use of USE_BDB

[Jo Rhett]

This makes sense.  The current code FYI does require 4.4 or higher, so 
44+ is accurate.

Xin LI wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Scot Hetzel wrote:
>> I have noticed that sysutils/cfengine is using USE_BDB incorrectly.
>>
>> USE_BDB?= 46
>>
>> The USE_BDB variable is not a user setable variable. If someone were
>> to read this Makefile, they would get the wrong impression that they
>> should set USE_BDB in there /etc/make.conf, ports.conf, or
>> portupgrade.conf file.   When they should instead be setting the
>> WITH_BDB_VER variable.
>>
>> The USE_BDB should be set to the minimum version of Berkeley DB that
>> the port will build with.
>>
>> USE_BDB= 44+
>>
>> And left up to the person installing the port to specify a higher version.
>>
>> If you want to take the choice away from the installer and have the
>> port always use BDB 4.6, then the port should use:
>>
>> USE_BDB= 46
>>
>> Which will prevent the use of BDB 4.4 and 4.5 from ever being used by this port.
> 
> I think the proper use of *_BDB variables is that:
> 
> WITH_BDB?=	46
> 
> (An advisory usage), and
> 
> USE_BDB=	yes
> 
> as in the attachment.
> 
> Cheers,
> - --
> Xin LI <delphij at delphij.net>	http://www.delphij.net/
> FreeBSD - The Power to Serve!
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.4 (FreeBSD)
> 
> iD8DBQFHguxRi+vbBBjt66ARAuHIAKC5rRxKOvsAveDPEoAXbQvKxa4giACfQEpO
> EJk7hRJusCc6sWaTpLfiCoM=
> =yUim
> -----END PGP SIGNATURE-----
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> freebsd-ports at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"

-- 
Jo Rhett
senior geek
Silicon Valley Colocation