qemu-devel port: please test -cdrom patch with non-FreeBSD guests

Juergen Lock nox at jelal.kn-bremen.de
Thu Nov 15 12:21:53 PST 2007


Hi!

 I would like to commit the patch below to the qemu-devel port that
chases recent FreeBSD atapi-cd.c commits (it fixes recent FreeBSD
guests no longer seeing a disc in the emulated cd drive) and I want to
make sure it doesn't introduce regressions, so I'd be grateful if you all
could test it with as many (especially non-FreeBSD) guests as possible,
using the emulated cd/dvd drive. (like, pass an iso as -cdrom and
try to access it from the guest, play with `eject cdrom' and
`change cdrom another.iso' monitor commands, etc.  Btw, at least Windows
guests also needed an expicit click on `eject' in the guest in order to
notice disc changes, so if thats still the case its at least not new.)

 Thanx,
	Juergen

Index: files/patch-hw-ide.c
@@ -0,0 +1,19 @@
+Index: qemu/hw/ide.c
+@@ -1339,6 +1341,8 @@
+                 case 0x2a:
+                     cpu_to_ube16(&buf[0], 28 + 6);
+                     buf[2] = 0x70;
++                    if (bdrv_is_inserted(s->bs))
++                        buf[2] = 0x40;
+                     buf[3] = 0;
+                     buf[4] = 0;
+                     buf[5] = 0;
+@@ -1347,7 +1351,7 @@
+ 
+                     buf[8] = 0x2a;
+                     buf[9] = 0x12;
+-                    buf[10] = 0x00;
++                    buf[10] = 0x08;
+                     buf[11] = 0x00;
+                     
+                     buf[12] = 0x70;


More information about the freebsd-ports mailing list