More speed increases for make-ing ports

Pav Lucistnik pav at FreeBSD.org
Thu May 24 08:28:39 UTC 2007


Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500:

> I'm getting kind of uncomfortable with the patch.  I looked some more
> in 
> bsd.gnome.mk and it seems to me that the suggested patch is really 
> equivalent to the patch enclosed here.
> 
> Why did the writer of bsd.gnome.mk have the rather complicated 
> construction which I am proposing to replace?

I don't know, we'd have to ask Joe Marcus. Here is the revision in
question:

http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23

You're basically reverting that revision. Perhaps our make(1) wasn't
smart enough those four years ago, I don't know.

> Prostý textový dokument příloha (eee)
> --- bsd.gnome.mk-orig	Mon Mar 19 23:13:36 2007
> +++ bsd.gnome.mk	Wed May 23 19:25:19 2007
> @@ -689,9 +689,9 @@
>  
>  # Then traverse through all components, check which of them
>  # exist in ${_USE_GNOME} and set variables accordingly
> +.ifdef _USE_GNOME
>  . for component in ${_USE_GNOME_ALL}
> -_COMP_TEST=	${_USE_GNOME:M${component}}
> -.  if ${_COMP_TEST:S/${component}//}!=${_COMP_TEST:S/  / /g}
> +.  if ${_USE_GNOME:M${component}}!=""
>  PATCH_DEPENDS+=	${${component}_PATCH_DEPENDS}
>  FETCH_DEPENDS+=	${${component}_FETCH_DEPENDS}
>  EXTRACT_DEPENDS+=${${component}_EXTRACT_DEPENDS}
> @@ -725,6 +725,7 @@
>  
>  .  endif
>  . endfor
> +.endif
>  .endif
>  
>  .if defined(GNOME_PRE_PATCH)
-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>

The Linimon's Rule: The More You Close, The More Will Come
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20070524/b9baa559/attachment.pgp


More information about the freebsd-ports mailing list