Time to abandon recursive pulling of dependencies?
Kris Kennaway
kris at obsecurity.org
Sat May 12 19:34:13 UTC 2007
On Sat, May 12, 2007 at 12:30:52PM -0700, Jeremy Chadwick wrote:
> On Sat, May 12, 2007 at 01:53:36PM -0500, Stephen Montgomery-Smith wrote:
> > I believe that if this function is optimized, that practically all of the
> > slowness issues we have seen with pkg_add, pkg_deinstall, etc, will be
> > solved. Give me a few days. I think I will be able to make it work very
> > much faster. For starters it uses a bubble sort. I can understand why they
> > don't want to use a quicksort, because they want to check complete integrety
> > of comparison tree (i.e. that there are no internal loops), but I recall
> > seeing an algorithm due perhaps to one of or both of Hopcroft and Tarjan
> > that uses a depth first search, maybe 20 years ago, that should be much
> > faster, and I think I could reproduce it.
>
> Please don't use a bubblesort, it's incredibly inefficient.
The *existing* algorithm is a bubble sort; Stephen is not proposing to
replace it with one.
Kris
More information about the freebsd-ports
mailing list