Generating INDEX

[Joe Marcus Clarke]

On Sat, 2007-04-14 at 00:32 +0200, Gerald Pfeifer wrote:
> On Fri, 13 Apr 2007, Rong-en Fan wrote:
> > No, the patch won't work. According to
> > http://www.freebsd.org/gnome/docs/porting.html,
> > the right way is always define WANT_GNOME which won't pull
> > any gnome dependencies unless USE_GNOME is used.
> > 
> > I think after USE_PERL5_BUILD line, add
> > 
> > WANT_GNOME=yes
> > 
> > and use += for USE_GNOME after bsd.port.pre.mk
> 
> Thanks.  This matches my reading of 
> http://www.freebsd.org/gnome/docs/porting.html as well, so I committed
> the patch at the end of this message to hopefully address the breakage.
> 
> On Fri, 13 Apr 2007, Pav Lucistnik wrote:
> >> I think after USE_PERL5_BUILD line, add
> >> 
> >> WANT_GNOME=yes
> >> 
> >> and use += for USE_GNOME after bsd.port.pre.mk
> > The usual workaround is
> > 
> > USE_GNOME=	# empty
> > 
> > .include <bsd.port.pre.mk>
> > 
> > USE_GNOME+=	foo bar baz
> 
> What Rong-en proposed matches my reading of our GNOME porting 
> documentation, and according to my reading of bsd.port.mk your 
> proposal is just another way of achieving the same result.  Is
> this correct?
> 
> What worries me more is that the same documentation also has:
> 
>   Note: You cannot add extra default USE_GNOME components after the 
>   .include <bsd.port.pre.mk>. That is, the following is wrong :
> 
>   .include <bsd.port.pre.mk>
> 
>   .if ${HAVE_GNOME:Mgnomelibs}!=""
>       USE_GNOME+= libgnome
>   .else
>       USE_GNOME+= gtk12  # WRONG!
>   .endif
>      
> and lang/gcc41 has the following right now after .include 
> <bsd.port.pre.mk>:
> 
>   USE_GNOME=    gtk20 libartlgpl2
> 
> Should we move the USE_GNOME=gtk20 part into lang/gcc41-withgcjawt
> and only keep USE_GNOME+=libartlgpl2 at this point in lang/gcc41 or
> is the current use okay in this specific setting?

The statement above affects the setting of PLIST_SUB.  If you are not
relying on the values of GNOME:, NOGNOME:, GNOMEDESKTOP:, and
NOGNOMEDESKTOP: in PLIST_SUB, then you don't need to worry.  In any
case, using USE_GNOME once after bsd.port.pre.mk is always fine.

Joe

> 
> Gerald
> 
> PS: For now I committed the patch below which ought to be correct in
> any case.  I won't be able to be online too much over the weekend, so
> if any of you please be more than welcome to apply any followup patch
> as needed if you are confident it is the right thing to do.
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v
> retrieving revision 1.318
> diff -u -3 -p -r1.318 Makefile
> --- Makefile	10 Apr 2007 05:24:27 -0000	1.318
> +++ Makefile	13 Apr 2007 22:06:51 -0000
> @@ -34,6 +34,7 @@ USE_BZIP2=	yes
>  USE_GMAKE=	yes
>  USE_ICONV=	yes
>  USE_PERL5_BUILD=yes
> +WANT_GNOME=	yes
>  
>  PATCH_WRKSRC=	${SRCDIR}
>  CONFIGURE_SCRIPT=	../${SRCDIR:C/${WRKDIR}//}/configure
> _______________________________________________
> freebsd-ports at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"
> 
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20070413/b21f9d22/attachment.pgp