Valgrind failures (was Re: cvs commit: src/sys/sys sched.h)

[David Xu]

On Saturday 25 November 2006 17:04, Matthew D. Fuller wrote:
> > trhodes     2006-11-11 16:27:52 UTC
> >
> >   Modified files:
> >     sys/sys              sched.h
> >   Log:
> >   Merge sys/posix4/sched.h into sys/sched.h.
> >
> >   Revision  Changes    Path
> >   1.29      +77 -3     src/sys/sys/sched.h
>
> This change seems to have broken the build of the valgrind* ports.
> The following patch seems to make it build nicely (applies to
> valgrind-snapshot with a few lines offset).  Neither appear to
> actually work on my Thursday -CURRENT, but I don't guess that's really
> related to this change.  Both versions dump core just trying to run on
> 'ls'.
>
>
> (The chosen OSVERSION is from an unrelated change ~30 minutes after
> the above)
>
>
> Index: Makefile
> ===================================================================
> RCS file: /usr/cvs/ports/devel/valgrind/Makefile,v
> retrieving revision 1.21
> diff -u -r1.21 Makefile
> --- Makefile	4 May 2006 21:41:10 -0000	1.21
> +++ Makefile	25 Nov 2006 08:42:52 -0000
> @@ -87,6 +87,10 @@
>  	${FIND} ${WRKSRC} -name "Makefile.in" -exec \
>  		${REINPLACE_CMD} -e "s/docs//g" {} \;
>  .endif
> +.if ${OSVERSION} >= 700025
> +	${REINPLACE_CMD} -e "s,posix4/sched\.h,sys/sched\.h," \
> +		${WRKSRC}/coregrind/vg_unsafe.h
> +.endif
>
>  post-install:
>  	@${INSTALL_DATA} ${WRKSRC}/coregrind/vg_unistd.h \

I think the ports should use /usr/include/sched.h which has
being existed for a long time.

Regards,
David Xu