portsclean deleting too many distfiles

[Sergey Matveychuk]

Jonathan Noack wrote:
> The first time I ran 'portsclean -D' after upgrading to portupgrade
> 2.1.4_2,1, it deleted all distfiles for ports that were not installed on
> that machine.  However, I have /usr/ports/distfiles shared via NFS to my
> cluster, so now all the distfiles for ports installed on other machines
> are gone.  The machine I ran portsclean on was headless, so I lost EVERY
> X-related distfile.  This is especially painful as these tend to be the
> biggest (e.g. OpenOffice is over 200MB).
> 
> From the portsclean man page on the -D/--distclean option:
> "Clean out all the distfiles that are not referenced by any port in the
> ports tree.  Specified twice (i.e. -DD), clean out all the distfiles
> that are not referenced by any port that is currently installed. (cf.
> DISTDIR)"
> 
> I did not specify it twice (because I have 'portsclean -D' aliased to
> 'pc') so I guess there is a regression in portupgrade 2.1.4.

I did not change anything in distclean() of portsclean(1). But I'll take
a look.

--
Dixi.
Sem.