cvs commit: ports/mail/dk-milter Makefile pkg-plist ports/mail/dk-milter/files milter-dk.sh.in

[Pav Lucistnik]

Sam Lawrance píše v út 17. 01. 2006 v 21:39 +1100:
> Over to ports@ ...
> 
> On 17/01/2006, at 10:50 AM, Doug Barton wrote:
> 
> > Pav Lucistnik wrote:
> >> pav         2006-01-15 09:11:04 UTC
> >>
> >>   FreeBSD ports repository
> >>
> >>   Modified files:
> >>     mail/dk-milter       Makefile pkg-plist
> >>     mail/dk-milter/files milter-dk.sh.in
> >>   Log:
> >>   - Convert RC script to rc_subr
> >>
> >>   PR:             ports/91595  http://www.FreeBSD.org/cgi/query- 
> >> pr.cgi?pr=91595
> >>   Submitted by:   Hirohisa Yamaguchi <umq at ueo.co.jp>
> >>
> >>   Revision  Changes    Path
> >>   1.6       +3 -2      ports/mail/dk-milter/Makefile
> >>   1.2       +43 -48    ports/mail/dk-milter/files/milter-dk.sh.in
> >>   1.2       +0 -1      ports/mail/dk-milter/pkg-plist
> >>
> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/ 
> >> Makefile.diff?&r1=1.5&r2=1.6&f=h
> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/files/ 
> >> milter-dk.sh.in.diff?&r1=1.1&r2=1.2&f=h
> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/pkg- 
> >> plist.diff?&r1=1.1&r2=1.2&f=h
> >
> > It's not a big enough issue to warrant a change for this port, but in
> > general it's a good idea if the name of the rc.d file is the same  
> > as what
> > the script PROVIDE's. This removes one potential source of  
> > confusion for users.
> 
> Is it worth a patch to portlint?  There are probably a stack of other  
> rc-related things that could be checked for, too.  For example, if an  
> rc script is in the packing list, warn to use USE_RC_SUBR.  Others?

If an rc.d script is in the packing list! Old styled scripts are not
affected. How will you check that from portlint?

-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>

With sufficient thrust, pigs fly just fine.
  -- RFC 1925
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060117/670e70b5/attachment.bin