[PATCH] security/courier-authlib-base: update rc.d script to REQUIRE mysql_client

[Doug Barton]

Ion-Mihai Tetcu wrote:
> On Thu, 12 Jan 2006 18:48:57 -0500
> Mike Jakubik <mikej at rogers.com> wrote:

>> I think the real solution would be to generate the required services 
>> dynamically based on what the port is compiled with. This obviously 
>> means some more work, but i think a lot of port maintainers will have
>> to go through this, to properly utilize RCng. Examples can be
>> apparently taken from the misc/compat5 port.
> 
> Or my mail/dspam-devel.

You definitely have some cool stuff in there! I would like to mention one 
little nit, that I was actually reminded of myself recently. When you do 
default variable values, it's better to do it like this:

dspam_enable=${dspam_enable-"NO"}

rather than with the colon. That way if the user has done this in 
/etc/rc.conf:  dspam_enable="" the default will still be no (since - 
replaces the value only if it's unset, whereas :- replaces if it is unset OR 
null). This isn't too meaningful for things like _enable where either result 
would have basically the same effect, but it is meaningful for things like 
_flags, where in your script, if the user did dspam_flags="" they would 
unexpectedly have nothing replaced with your default.

hth,

Doug

-- 

     This .signature sanitized for your protection