FreeBSD Port: mimedefang-2.54

[Wes Peters]

On Friday 10 February 2006 23:47, you wrote:
> On Feb 8, 2006, at 11:34 PM, Doug Barton wrote:
> > n j wrote:
> >> Hello,
> >>
> >> Don't know if this has been reported and/or fixed...
> >>
> >> After installing mimedefang, the attempt to start it using rc.d
> >> startup script, mimedefang.sh, succeeds, but reports the following:
> >>
> >> "Starting mimedefang:                                        [:
> >> missing ]
> >> [  OK  ]"
> >>
> >> A few hours later (well, I'm no expert) :), I figured what's wrong
> >> with the installation. It appears that startup script has a bug. On
> >> lines 180 and 218, a space is missing before the closing square
> >> bracket, after the SPOOLDIR variable:
> >> the line should read [ -n "$SPOOLDIR" ] && echo "-z $SPOOLDIR"
> >> instead
> >> of [ -n "$SPOOLDIR"] && echo "-z $SPOOLDIR" (note the space).
> >
> > Good catch. This is actually a bug in the script as provided by the
> > vendor,
> > so you might want to report this upstream as well.
>
> This is caused by David (Skoll, creator of mimedefang) using bash as
> the system shell (like all good Linux kiddies).  I'll fix the port
> and report it to David.  Getting rid of the stupid "OK" garbage would
> be nice, too.

OK, so this is fixed in the latest MIMEdefang.  David Skoll is a great guy and 
very responsive to bug reports.

On the other hand, I'd still prefer to get rid of the Linux/SVR34 
[  OK  ]/[FAILED] silliness, so I have a patch for that.  Given that I 
managed this immediately AFTER ports freeze, it won't show up until after the 
5.5/6.1 cycle, my bad.  I've attached the patch file if you want to try it, 
just dump it in the port files/ directory and have at it.

> Note: yes, I used mimedefang, but not this script.  We have custom
> perl modules that start every piece of our system.
>
> >> While I'm at it, it would be nice if mimedefang installation somehow
> >> modified sendmail startup script to automatically start
> >> mimedefang, as
> >> sendmail with mimedefang configured but not started doesn't work
> >> anyway. But this is more of an idea to think about than an RFE :).
> >
> > One way to handled this (and in fact it would be preferred at this
> > point)
> > would be to install this init-script in ${PREFIX}/libexec (perhaps as
> > mimedefang-init), and write a simple rc.d script that called that
> > script at
> > boot. The example in the Porter's Handbook could be simplified and
> > used in
> > this situation.
>
> I'll take a look at it.  Once the mimedefang startup script works,
> it's not clear that this is a problem.

I'll get to this after the release cycle is done.  Having it start with a 
properly coded rc.d script that configures the way FreeBSD expects will be a 
big win.  Sorry I didn't have enough spare time to fix it before the release.  
It should be a pretty simple script, but ENOTIME.

-- 
         Where am I, and what am I doing in this handbasket?
Wes Peters                                                wes at softweyr.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-init-script.in
Type: text/x-diff
Size: 1655 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20060223/72212edf/patch-init-script.bin