PREFIX problems...

[Sam Lawrance]

On 11/02/2006, at 12:09 AM, Anders Troback wrote:

> On Fri, 10 Feb 2006 14:26:01 +0200
> Vasil Dimov <vd at FreeBSD.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On Fri, Feb 10, 2006 at 12:45:09PM +0100, Anders Troback wrote:
>> ...
>>> The former maintainer did some things that portlint don't like, the
>>> last line are not .include <bsd.port.mk> and when I move down the
>>> line the PREFIX are ignored!
>>>
>>> make install should put all files in $PREFIX/bigsister but when I
>>> put .include <bsd.port.mk> to the bottom of Makefile make install
>>> puts the files in /usr/local.
>> ...
>>
>> Have you tried
>>
>> PREFIX?=	${LOCALBASE}/bigsister
>> CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
>> CONFIGURE_ARGS=	--with-cgi=${BS_CGI_PATH} \
>> 		--with-perlext=${BS_PERL_EXT} \
>> 		--with-url=${BS_URL} \
>> 		--with-user=${BS_USER}
>>
>> - --
>> Vasil Dimov
>> -----BEGIN PGP SIGNATURE-----
>>
>> iD8DBQFD7IZZFw6SP/bBpCARAs8VAJoDk2EOFsP5Qe6RG0wQxbwdutEp4wCggo58
>> F2lN3SZ1Rr6c+bRTSPYsIAw=
>> =q+IX
>> -----END PGP SIGNATURE-----
>
> I have now:-)
>
> That fixed it!
>
> Is this a "legal" way to go?

No, it's best that you don't set PREFIX (especially like that - what  
happens if someone comes along and does "make install PREFIX=/usr/ 
opt"?).

Just passing PREFIX in CONFIGURE_ARGS may not be enough.  You should  
probably also do:

MAKE_ENV+=	PREFIX=${PREFIX}/${PORTNAME}

Otherwise, the submake will get PREFIX=${PREFIX} (which is why your  
port installed into /usr/local).