distfile belongs to?

[Wesley Shields]

On Tue, Dec 05, 2006 at 01:59:04PM -0800, Doug Barton wrote:
> Wesley Shields wrote:
> 
> >> I'd like to finalize how it should look in +CONTENTS before I make this
> >> change, but it will get done eventually.  :)
> >>
> >> One way I was exploring is adding
> >>
> >> @comment DISTFILE:$filename:$size:$md5:$sha256
> 
> I think that's good, the other information might come in handy down
> the road. One thing you might want to consider is to put the md5 sum
> at the end, since at some point down the road (maybe years from now,
> but still ...) we're likely to drop md5 altogether.

Good idea.  :)

> >> into the generated plist.  This way we shouldn't have to change
> >> pkg_create and only modify pkg_info and other tools.  I haven't tested
> >> this fully but it was just a fairly easy and concise way that I believe
> >> will work. By adding it to +CONTENTS using some type of @comment line we
> >> can avoid changing pkg_create and make for easier adoption.  The only
> >> changes that will need to be made will be to those programs which
> >> process +CONTENTS directly, and even those modifications will be
> >> minimal.
> 
> I think you're probably right about this, but I'd like to hear from
> some people who are more knowledgeable about the port's internals than
> I am first.

As would I.  I'll give it a few days before I send-pr anything.  If
nothing else it will get discussed then.

> I should have spoken up earlier, but you have a couple of
> inefficiencies and duplicated code that doesn't have to be there. Take
> a look at the attached, which also implements the change I mentioned
> above. Also, for something like this where you just need the Nth
> element of a line that is in a standard format, cut(1) is a lot more
> efficient than awk.

Thanks for pointing this out.  I'm still new to hacking at b.p.m and was
looking for a way to do just that.  I kept trying to put the conditional
inside the for loop, which wasn't working.  Thanks for the help, I
appreciate it.

-- WXS