FreeBSD Port: qmail-1.03_3
kris at obsecurity.org
Tue Jan 25 17:43:38 PST 2005
On Tue, Jan 25, 2005 at 05:36:49PM -0800, Michael Sierchio wrote:
> You have added a patch which is totally unneccesary, and I
> suggest that it be removed:
> in your patch-qmail-local....
> - while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))
> + while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')))
> This is totally bogus, the original code is correct. Please do not
> make changes to contributed code simply because it makes it easier
> for you to understand. There is no semantic difference between the
> two, ERGO the patch should not exist. Please remove it.
> Shall I file a PR?
You could try sending a more politely worded email next time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20050125/ff39077b/attachment.bin
More information about the freebsd-ports