WITHOUT_X11 knob for mplayer

[Kirill Ponomarew]

On Tue, Jan 18, 2005 at 12:43:44PM +0100, Jeremie Le Hen wrote:
> I had a look in the porter's handbook.  Here are the drawbacks I found
> about using USE_IMAKE knob:
> 
> %%%
>   Define USE_XLIB=yes if your port requires the X Window System to be
>   installed (it is implied by USE_IMAKE).
> 
>   USE_IMAKE	The port uses imake. Implies USE_X_PREFIX.
> %%%
> 
> Obviously, this would make my patch completely useless :-).
> 
> Whereas it can be interpreted as an inconsistency in the mplayer build
> system (usage of imake(1) even if not linked with X11 libs), my opinion
> is that this is a ports system weakness for this particular situation.
> Nevertheless I'm convinced there are good reasons to have the USE_IMAKE
> knob implying the USE_XLIB one.
> 
> I would like to circomvent the use of USE_IMAKE here.  Florent stated
> that the imake version depends on X_WINDOWS_SYSTEM but my BUILD_DEPENDS
> is only used when the WITHOUT_X11 knob is on.  Thus I think we could
> use an arbitrary version of imake (say imake-6).  This won't be very
> fair for those still running XFree86 as X_WINDOWS_SYSTEM and building
> mplayer WITHOUT_X11, but there are obviously a very few.
> 
> Do you all agree with me ?

Did you try ?

BUILD_DEPENDS=   imake:${X_IMAKE_PORT}

-Kirill