portsperf (bsd.port.mk performance bugs fixed) redux

[Anton Berezin]

On Thu, Feb 17, 2005 at 03:59:13PM -0500, Brian Fundakowski Feldman wrote:
> Well, guys, it's been a while since the last installment of portsperf.
> Without further ado, here's a fix that bring port vulnerability check
> time down from almost two minutes to almost instantaneous (on my
> machine)!  I was always wondering why ports have been so terribly slow
> since around some time last year, and a good 2000 pids get recycled
> just doing "make extract":
>  <@green_> now:
>  <@green_> green# time make extract
>  <@green_> ===>  Extracting for mp3gain-1.3.2
>  <@green_> => Checksum OK for mp3gain132_src.zip.
>  <@green_> ===>   mp3gain-1.3.2 depends on executable: unzip - found
>  <@green_> 0.127u 1.132s 0:01.49 83.8%     108+497k 15+0io 8pf+0w
> 
>  <@green_> then:
>  <@green_> green# time make extract
>  <@green_> ===>  Extracting for mp3gain-1.3.2
>  <@green_> => Checksum OK for mp3gain132_src.zip.
>  <@green_> ===>   mp3gain-1.3.2 depends on executable: unzip - found
>  <@green_> 5.308u 82.765s 1:42.05 86.2%    92+193k 10+0io 12pf+0w

> Index: bsd.port.mk
> ===================================================================
> RCS file: /usr/ncvs/ports/Mk/bsd.port.mk,v
> retrieving revision 1.509
> diff -u -r1.509 bsd.port.mk
> --- bsd.port.mk	9 Feb 2005 09:07:37 -0000	1.509
> +++ bsd.port.mk	17 Feb 2005 20:37:17 -0000
> @@ -3009,14 +3009,18 @@
>  		if [ "$$audit_created" -lt "$$audit_expiry" ]; then \
>  			${ECHO_MSG} "===>  WARNING: Vulnerability database out of date, checking anyway"; \
>  		fi; \
> -		vlist=`${_EXTRACT_AUDITFILE} | ${GREP} "${PORTNAME}" | \
> -			${AWK} -F\| ' /^[^#]/ { \

Are you sure that the "then" part in your test was done with bsd.port.mk
that contains this `${GREP} "${PORTNAME}"' snippet, and not before it
was added?  It is a recent addition, and it serves exactly the purpose
of speeding up vulnerabilities checking.

root at hrum audio/mp3gain# time make extract
===>  Extracting for mp3gain-1.3.2
=> Checksum OK for mp3gain132_src.zip.
===>   mp3gain-1.3.2 depends on executable: unzip - found
make extract  0.14s user 0.11s system 100% cpu 0.249 total

Recent stock bsd.port.mk, portaudit installed and enabled.

Cheers,
\Anton.
-- 
The moronity of the universe is a monotonically increasing function. --
Jarkko Hietaniemi