patch for mille in freebsd-games

guzman at zalem.net guzman at zalem.net
Tue Feb 1 05:19:33 PST 2005


i'm confused and sorry... I forgot to include the patches...

On Tue, Feb 01, 2005 at 01:49:01PM +0100, guzman at zalem.net wrote:
> Hi,
> I noticed that the game mille in the ports freebsd-games doesn't respect the man rule, when a safety card is player it's "always entitles the player to an extra turn".
> the fact is that is doesn't do it. It comes from this error during compile :
> cc -O -pipe   -c move.c
> move.c: In function `playcard':
> move.c:348: warning: comparison is always false due to limited range of data type
> 
> move.c :
> Next = (Next == -1 ? FALSE : TRUE);
> 
> where Next is a bool, so an usigned char (from curses.h).
> it's easy to fix, just making Next a char and all back to normal.
> I've attached patches if you ever interested in correcting this ports :)
> 
> I've checked on the last pkg available, and in the source, the error is present.
> 
> Sincerely,
> Guzman
> guzman at zalem.net
-------------- next part --------------
--- mille/extern.c.bak	Tue Feb  1 11:05:02 2005
+++ mille/extern.c	Tue Feb  1 10:17:19 2005
@@ -47,10 +47,11 @@
 
 bool	Debug,			/* set if debugging code on		*/
 	Finished,		/* set if current hand is finished	*/
-	Next,			/* set if changing players		*/
 	On_exit,		/* set if game saved on exiting		*/
 	Order,			/* set if hand should be sorted		*/
 	Saved;			/* set if game just saved		*/
+
+char	Next;			/* set if changing players		*/
 
 char	*Fromfile = NULL,	/* startup file for game		*/
 	Initstr[100];		/* initial string for error field	*/
-------------- next part --------------
--- mille/mille.h.bak	Tue Feb  1 11:04:57 2005
+++ mille/mille.h	Tue Feb  1 11:08:55 2005
@@ -212,7 +212,8 @@
  * externals
  */
 
-extern bool	Debug, Finished, Next, On_exit, Order, Saved;
+extern bool	Debug, Finished, On_exit, Order, Saved;
+extern char	Next;
 
 extern const char	*C_fmt, **C_name;
 extern char	*Fromfile, Initstr[];


More information about the freebsd-ports mailing list