Fix dbus to use /bin/sh

Adam Weinberger adamw at magnesium.net
Sun Apr 3 22:21:21 PDT 2005


jimmie james wrote:
> On Apr 3, 2005 10:53 PM, Adam Weinberger <adamw at magnesium.net> wrote:
> 
>>On Sun, 2005-03-04 at 22:28 -0400, jimmie james wrote:
>>
>>>In ports/devel/dbus/Makefile we find "BUILD_DEPENDS?=
>>>bash:${PORTSDIR}/shells/bash" which is a new build depend.
>>>
>>>According to: http://www.freedesktop.org/Software/dbus  the only
>>>depend is a XML parser "D-BUS' only *required* dependency is an XML
>>>parser (either libxml or expat)."
>>>
>>>No notice of change on the freedesktop site, or /usr/ports/UPDATING.
>>>
>>>Why are we using GNU shells, when /bin/sh is/should be standard on every system?
>>>
>>>Related links:
>>>https://bugs.freedesktop.org/show_bug.cgi?id=1172
>>>https://bugs.freedesktop.org/show_bug.cgi?id=1674
>>
>>On FreeBSD, /bin/sh is Ash. FreeBSD does not ship with BAsh. On
>>Linux, /bin/sh is BAsh. The Linux world likes to assume that if it works
>>on Linux, it will work on anything (or they don't care).
>>
>>Fd.o doesn't say that it needs BAsh, because they assume that /bin/sh
>>*IS* BAsh.
>>
>># Adam
>>
>>--
>>Adam Weinberger
>>adamw at magnesium.net || adamw at FreeBSD.org
>>adamw at vectors.cx    ||   adamw at gnome.org
>>http://www.vectors.cx
> 
> 
> 
> Well, after giving in, and installing bash: bash-3.0.16_1       The
> GNU Project's Bourne Again SHell
> 
> The error is still popping up: 
>  cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I/usr/local/include/glib-2.0
> -I/usr/local/lib/glib-2.0/include -DDBUS_COMPILATION=1
> -DDBUS_LOCALEDIR=\"/usr/local/@DATADIRNAME@/locale\"
> -DDBUS_API_SUBJECT_TO_CHANGE=1 -I/usr/local/include -Os -pipe
> -march=pentiumpro -Wall -Wchar-subscripts -Wmissing-declarations
> -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align
> -Wsign-compare -c dbus-gobject.c -Wp,-MD,.deps/dbus-gobject.TPlo 
> -fPIC -DPIC -o .libs/dbus-gobject.o
> dbus-gobject.c: In function `write_interface':
> dbus-gobject.c:400: syntax error before `const'
> dbus-gobject.c:405: `args' undeclared (first use in this function)
> dbus-gobject.c:405: (Each undeclared identifier is reported only once
> dbus-gobject.c:405: for each function it appears in.)
> gmake[2]: *** [dbus-gobject.lo] Error 1
> gmake[2]: Leaving directory `/usr/ports/devel/dbus/work/dbus-0.32/glib'
> gmake[1]: *** [all-recursive] Error 1
> gmake[1]: Leaving directory `/usr/ports/devel/dbus/work/dbus-0.32'
> gmake: *** [all] Error 2
> *** Error code 2
> 
> So, it appears to be a port error, not a shell error(what to do with
> bash, since it'll never be used)
> 
> # $FreeBSD: ports/devel/dbus/Makefile,v 1.15 2005/04/02 21:06:24 marcus Exp $

Aack. Right you are. I've committed a fix.

# Adam


-- 

Adam Weinberger
adamw at magnesium.net || adamw at FreeBSD.org
adamw at vectors.cx    ||   adamw at gnome.org
http://www.vectors.cx


More information about the freebsd-ports mailing list