Non-Maintainer update: editors/nedit - Add BUILD_BROKEN_NEDIT to build with Open Motif 2.2.2 (default)

[Andrew J.Caines]

>Submitter-Id:	current-users
>Originator:	Andrew J. Caines
>Organization:	H.A.L. Plant
>Confidential:	no 
>Synopsis:	Non-Maintainer update: editors/nedit - Add BUILD_BROKEN_NEDIT to build with Open Motif 2.2.2 (default)
>Severity:	serious
>Priority:	high
>Category:	ports
>Class:		update
>Release:	FreeBSD 4.10-STABLE i386
>Environment:
System: FreeBSD hal9000.halplant.com 4.10-STABLE FreeBSD 4.10-STABLE #0: Fri Jun 4 08:39:15 EDT 2004 toor at hal9000.halplant.com:/data/obj/data/src/sys/HAL9000 i386


	
>Description:
	Port build fails with default Motif (open-motif-2.2.2_2) because NEdit authors don't want to build against Open Motif 2.2.2:

----8<----
===>  Building for nedit-5.4
(cd util;  make -f Makefile.freebsd verify_config &&  make -f Makefile.freebsd libNUtil.a)
ccache gcc -O2 -pipe -march=pentium -O -I/usr/X11R6/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM -o check_lin_tif check_lin_tif.c
./check_lin_tif
Open Motif or OSF Motif detected.
@(#)Motif Version 2.2.2
ERROR:  Bad Open Motif Version:
        @(#)Motif Version 2.2.2

This version of Open Motif is known to be broken and is
thus unsupported by the NEdit developers.  It will probably
cause NEdit to crash frequently.  Check these pages for a more
detailed description of the problems with this version:
        http://www.motifdeveloper.com/tips/tip22.html
        http://www.motifdeveloper.com/tips/Motif22Review.pdf

NEdit is known to work with LessTif versions:
        0.92.32
        0.93.0
        0.93.12
        0.93.18
and is known to be very stable with Open Motif version 2.1.30,
which is freely available from several sources, including:
        http://www.opengroup.org/openmotif/
        http://www.metrolink.com/products/motif/open_motif2-1-30.html
        http://www.ist.co.uk/DOWNLOADS/motif_download.html

Also, unless you need a customized NEdit you should STRONGLY
consider downloading a pre-built binary from http://www.nedit.org,
since these are the most stable versions.

If you really want to build a known-bad version of NEdit you
can override this sanity check by adding -DBUILD_BROKEN_NEDIT
to the CFLAGS variable in your platform's Makefile (e.g.
makefiles/Makefile.linux)
*** Error code 1

Stop in /data/ports/editors/nedit/work/nedit-5.4/util.
*** Error code 1

Stop in /data/ports/editors/nedit/work/nedit-5.4.
*** Error code 1

Stop in /data/ports/editors/nedit.
----8<----
>How-To-Repeat:
	Try to build port
>Fix:

	Add -DBUILD_BROKEN_NEDIT to the nedit FreeBSD Makefile:

----8<----
diff -ruN nedit.orig/files/patch-ac nedit/files/patch-ac
--- nedit.orig/files/patch-ac	Sat Jun  5 21:19:54 2004
+++ nedit/files/patch-ac	Sat Jun  5 21:11:27 2004
@@ -1,5 +1,5 @@
---- makefiles/Makefile.freebsd.orig	Sun Sep 28 15:03:10 2003
-+++ makefiles/Makefile.freebsd	Sat Feb  7 15:00:18 2004
+--- makefiles/Makefile.freebsd.orig	Sun Sep 28 11:03:10 2003
++++ makefiles/Makefile.freebsd	Sat Jun  5 21:10:26 2004
 @@ -1,6 +1,6 @@
  # $Id: Makefile.freebsd,v 1.5.2.1 2003/09/28 15:03:10 edg Exp $
 -CC=cc
@@ -15,7 +15,7 @@
  #
 -CFLAGS=-O -I${PREFIX}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM
 -LIBS= ${MOTIFLIB} -L${PREFIX}/lib -lm -lXpm -lXext -lXt -lSM -lICE -lX11
-+CFLAGS+=-O -I${X11BASE}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM
++CFLAGS+=-O -I${X11BASE}/include -DUSE_DIRENT -DUSE_LPR_PRINT_CMD -DUSE_XMIM -DBUILD_BROKEN_NEDIT
 +LIBS+= ${MOTIFLIB} -L${X11BASE}/lib -lm -lXpm -lXext -lXt -lSM -lICE -lX11
  
  include Makefile.common


----8<----

Note that I've modified patch-ac which already changes the nedit FreeBSD Makefile.

There has been some discussion about the validity of the NEdit authors' position on stability, however I suggest this patch independently of this argument for the simple reason that the port fails to install by default. See the freebsd-ports archive for details.