INDEX patch

[Kris Kennaway]

On Wed, Jun 02, 2004 at 03:40:06PM +0200, Oliver Eikemeier wrote:
> Kris Kennaway wrote:
> 
> >On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote:
> >
> >>Kris Kennaway wrote:
> >>
> >>
> >>>A previous commit to bsd.port.mk broke the reporting of missing
> >>>dependencies from 'make index'.  This patch restores it (and makes
> >>>these errors fatal).  I plan to commit it soon.
> >>>
> >>>Kris
> >>
> >>May I suggest the following patch:
> >>
> >>- check for existence of perl (cf. my RFC on ports-developers)
> >>- enables the use of `env PATH= /usr/bin/make describe' (nice for testing)
> >
> >Nice idea, but running this test 11000 times is suboptimal :-)
> 
> Because test is a sh-builtin, and the file system should cache this 
> information
> I don't expect to see any difference. Especially since spawning perl 11000 
> times
> is more than suboptimal ;) You didn't mean this serious, did you?

I did, because I care about small pessimizations of the INDEX build.
Sometimes they're not small.  Did you benchmark it?

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20040602/8a4e40c9/attachment.bin