tk84 port broken under 5.2

[Jim Segrave]

I just cvsupped the ports tree at about 21:00 UTC on 3 July on my
laptop running 5.2 from 30 May. I was trying to build the current 
/usr/ports/graphics/ftgl port, which tries to build
/usr/ports/x11-toolkits/tk84. This fails:


root at jes-2.demon.nl:/usr/ports/x11-toolkits/tk84# make 2>&1 | tee make.out
===>  Vulnerability check disabled
===>  Extracting for tk-8.4.6,1
>> Checksum OK for tk8.4.6-src.tar.gz.
===>  Patching for tk-8.4.6,1
===>  Applying FreeBSD patches for tk-8.4.6,1
===>   tk-8.4.6,1 depends on file: /nonexistent - not found
===>    Verifying extract for /nonexistent in /usr/ports/lang/tcl84
===>  Vulnerability check disabled
===>  Extracting for tcl-8.4.6_1,1
>> Checksum OK for tcl8.4.6-src.tar.gz.
===>   Returning to build of tk-8.4.6,1
===>   tk-8.4.6,1 depends on shared library: tcl84.1 - found
===>   tk-8.4.6,1 depends on shared library: X11.6 - found
===>  Configuring for tk-8.4.6,1
creating cache ./config.cache
checking for Tcl configuration... found /usr/local/lib/tcl8.4/tclConfig.sh
checking for existence of /usr/local/lib/tcl8.4/tclConfig.sh... loading
checking whether to use symlinks for manpages... no
checking compression for manpages... no
checking for gcc... cc
checking whether the C compiler (cc -O -pipe  ) works... yes
checking whether the C compiler (cc -O -pipe  ) is a cross-compiler... no
checking whether we are using GNU C... yes
checking whether cc accepts -g... yes
checking how to run the C preprocessor... cc -E
checking for unistd.h... yes
checking for limits.h... yes
checking for building with threads... no (default)
checking if the compiler understands -pipe... yes
checking for required early compiler flags... none
checking for 64-bit integer type... long long
checking for struct dirent64... no
checking for struct stat64... no
checking for off64_t... no
checking how to build libraries... shared
checking for ranlib... ranlib
checking if 64bit support is requested... no
checking if 64bit Sparc VIS support is requested... no
checking system version (for dynamic loading)... FreeBSD-5.2-CURRENT
checking for dlopen in -ldl... no
checking for ar... ar
checking for build with symbols... no
checking for sin... no
checking for main in -lieee... no
checking stdlib.h... yes
checking fd_set and sys/select... yes
checking for ANSI C header files... yes
checking for mode_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for uid_t in sys/types.h... yes
checking for sys/time.h... yes
checking whether time.h and sys/time.h may both be included... yes
checking pw_gecos in struct pwd... yes
checking for X... libraries /usr/X11R6/lib, headers /usr/X11R6/include
checking for main in -lXbsd... no
checking for connect... yes
checking for gethostbyname... yes
checking for sin... (cached) no
checking for main in -lieee... (cached) no
checking whether char is unsigned... no
checking for strtod... yes
checking for Solaris2.4/Tru64 strtod bugs... ok
updating cache ./config.cache
creating ./config.status
creating Makefile
creating tkConfig.sh
/usr/bin/sed -i.bak -e 's=/usr/ports=${WRKDIRPREFIX}/usr/ports='  /usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix/tkConfig.sh
===>  Building for tk-8.4.6,1
cc -pipe -c -O -pipe   -Wall -Wconversion -Wno-implicit-int -fPIC  -I/usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix -I/usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix/../generic  -I/usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix/../bitmaps -I/tmp/a/ports/lang/tcl84/work/tcl8.4.4/generic -I/usr/X11R6/include  -DHAVE_UNISTD_H=1 -DHAVE_LIMITS_H=1 -DTCL_WIDE_INT_TYPE=long\ long -DSTDC_HEADERS=1 -DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_PW_GECOS=1      -DTCL_NO_DEPRECATED -DUSE_TCL_STUBS /usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix/../generic/tk3d.c
In file included from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tkInt.h:21,
                 from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk3d.h:18,
                 from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk3d.c:16:
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:70:20: tcl.h: No such file or directory
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:72:9: #error Tk 8.4 must be compiled with tcl.h from Tcl 8.4
In file included from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tkInt.h:21,
                 from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk3d.h:18,
                 from /usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk3d.c:16:
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:140: error: syntax error before "char"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:204: error: syntax error before "ClientData"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:231: error: syntax error before "_ANSI_ARGS_"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:234: error: syntax error before '*' token
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:234: error: syntax error before "_ANSI_ARGS_"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:236: error: syntax error before "_ANSI_ARGS_"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:238: error: syntax error before "_ANSI_ARGS_"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:243: error: syntax error before "Tk_CustomOptionSetProc"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:283: error: syntax error before "Tcl_Obj"
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk.h:337: error: syntax error before "_ANSI_ARGS_"

[snip a few hundred lines]
/usr/ports/x11-toolkits/tk84/work/tk8.4.6/generic/tk3d.c:87: error: syntax error before '{' token
*** Error code 1

Stop in /usr/ports/x11-toolkits/tk84/work/tk8.4.6/unix.
*** Error code 1

Stop in /usr/ports/x11-toolkits/tk84.

The first error reported refers to a link in tk.h:

    140 typedef CONST char *Tk_Uid;

I tried for a lark doing:

make clean;export CFLAGS="-DCONST=const";make

This reduced the error count but left a lot of others still
unresolved. It appears something fairly fundamental is broken - tk83
builds without a problem



-- 
Jim Segrave           jes at jes-2.demon.nl