gnome-terminal sucks

[David Xu]

Joe Marcus Clarke wrote:

>On Mon, 2004-08-23 at 09:03, Joe Marcus Clarke wrote:
>  
>
>>On Mon, 2004-08-23 at 08:34, David Xu wrote:
>>    
>>
>>>After I maximized gnome-terminal window,  whenever I drag terminal
>>>window's scrollbar down to scroll forward contents, there is always
>>>some garbage left on screen:
>>>http://people.freebsd.org/~davidxu/screenshot.png
>>>The bug is there from version to version, this really sucks!
>>>      
>>>
>>Wow, that does really suck.  I don't see it here even with your
>>zh_CN.GB2312 locale.  What font are you using?  I tested Bitstream Mono
>>and Courier, and both work okay.
>>
>>http://www.marcuscom.com/downloads/gnome-terminal.png
>>    
>>
>
>David, this looks like it might be
>http://bugzilla.gnome.org/show_bug.cgi?id=146925.  There is a vte patch
>pointer in that bug.  Can you apply that to vte, and let me know if it
>solves your problem?  Thanks.
>
>  
>
Wow, the patch works for me! I pasted it here:

diff -ur vte-0.11.11.orig/src/vte.c vte-0.11.11/src/vte.c
--- vte-0.11.11.orig/src/vte.c	2004-05-02 03:43:01.000000000 -0300
+++ vte-0.11.11/src/vte.c	2004-07-09 21:21:01.000000000 -0300
@@ -13793,7 +13793,7 @@
 	row = MAX(0, (area->y - VTE_PAD_WIDTH) / height);
 	row_stop = MIN(howmany((area->y - VTE_PAD_WIDTH) + area->height,
 			       height),
-		       terminal->row_count - 1);
+		       terminal->row_count);
 	col = MAX(0, (area->x - VTE_PAD_WIDTH) / width);
 	col_stop = MIN(howmany((area->x - VTE_PAD_WIDTH) + area->width,
 			       width),


Thanks,
David Xu