Re Regression: Playing QT files from mplayer stopped working in
5.1
Ruslan Ermilov
ru at freebsd.org
Mon Jun 9 03:55:14 PDT 2003
On Mon, Jun 09, 2003 at 11:22:45AM +0200, Alexander Leidinger wrote:
> On Mon, 9 Jun 2003 10:28:33 +0200
> ted at NLnetLabs.nl (Ted Lindgreen) wrote:
>
> > However, I guess that mplayer has had this error already, but that
> > a change in uthread_close.c as of May 31 has caused this problem
> > to show up now.
> > In particular: the unprotected usage of a very large value of "fd"
> > in "_thread_fd_table[fd]" leads to the segmentation violation.
> >
> > Previously the systemcall just returned an error without getting
> > into a segmentation violation.
>
> > Question:
> > shouldn't _close in uthread_close.c do some sanity check on "fd"
> > before using it as an array index?
>
> Try the attached patch.
>
Alexander,
This patch looks great. Please commit it.
--
Ruslan Ermilov Sysadmin and DBA,
ru at sunbay.com Sunbay Software Ltd,
ru at FreeBSD.org FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20030609/58180152/attachment.bin
More information about the freebsd-ports
mailing list