[Bug 200555] [patch] improve ftp/curl OPENSSL vs. GSSAPI_BASE sanity check

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200555

            Bug ID: 200555
           Summary: [patch] improve ftp/curl OPENSSL vs. GSSAPI_BASE
                    sanity check
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: sunpoet at FreeBSD.org
          Reporter: truckman at FreeBSD.org
          Keywords: patch
          Assignee: sunpoet at FreeBSD.org
             Flags: maintainer-feedback?(sunpoet at FreeBSD.org)

Created attachment 157314
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=157314&action=edit
patch to improve OPENSSL vs. GSSAPI_BASE sanity check

When doing a poudriere build of ftp/curl and WITH_OPENSSL_PORT=yes included in
make.conf, bsd.openssl.mk will cause OPENSSL_PORT to be installed as a build
dependency, but the resulting curl package gets linked to the base version of
openssl if the GSSAPI_BASE options is set (default).

There is some sanity check logic in ftp/curl/Makefile that attempts to catch
this, but it misses some cases:
  * If the OPENSSL option is set and WITH_OPENSSL_PORT is defined, then we
    always want to link to OPENSSL_PORT.

  * If the OPENSSL option is set in a non-poudriere build and no WITH_OPENSSL_*
    preferences are specified, bsd.openssl.mk will check to see whether
    the openssl or libressl port is installed and if so it will expect to use
    that for the build.  Note: poudriere builds will be in a clean environment,
    so they will default to using openssl from base.

Setting OPENSSL_PORT does not cause poudriere to install OPENSSL_PORT as a
build dependency before building curl, so testing OPENSSL_PORT is not useful as
part of the sanity check.

If base openssl is not installed, bsd.openssl.mk will add OPENSSL_PORT as a
build dependency, but this case should not conflict with GSSAPI_BASE.

The attached patch attempts to match the GSSAPI_BASE sanity check logic to the
logic in bsd.openssl.mk.  It also tweaks the message and removes some
extraneous whitespace.

-- 
You are receiving this mail because:
You are the assignee for the bug.