[Bug 199081] [revive port] mail/smfsav: Add staging support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199081

Dmitry Marakasov <amdmi3 at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Assignee|freebsd-ports-bugs at FreeBSD. |amdmi3 at FreeBSD.org
                   |org                         |

--- Comment #6 from Dmitry Marakasov <amdmi3 at FreeBSD.org> ---
Why don't we change user name to "smfs" which is upstream default?

# Run as a selected user (smf-sav must be started by root)
#
# Default: smfs

Also I suggest the following set of changes:

- Add LICENSE_FILE
- Use -lpthread as threading ldflags as it has been decided
- Simplify installation - no need to split do-install and post-install, do need
to install docs conditionally as this is handled automatically

diff -ruN smfsav.orig/Makefile smfsav/Makefile
--- smfsav.orig/Makefile        2015-05-29 21:20:18.470625000 +0300
+++ smfsav/Makefile     2015-05-29 21:15:04.043203000 +0300
@@ -13,18 +13,17 @@
 COMMENT=       Sendmail Sender Address Validator

 LICENSE=       GPLv2
+LICENSE_FILE=  ${WRKSRC}/COPYING

 USERS=         smfsav
 GROUPS=                smfsav

 OPTIONS_DEFINE=        DOCS

-.include <bsd.port.options.mk>
-
 USE_RC_SUBR=   smfsav

 CPPFLAGS+=     -D_REENTRANT
-LDFLAGS+=      -lmilter -pthread
+LDFLAGS+=      -lmilter -lpthread

 SMFSAV_RUN_DIR?=/var/run/smfsav
 SUB_FILES+=    pkg-message
@@ -38,12 +37,8 @@
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/smf-sav ${STAGEDIR}${PREFIX}/sbin/smfsav
        ${INSTALL_DATA} ${WRKSRC}/smf-sav.conf
${STAGEDIR}${PREFIX}/etc/smfsav.conf.sample
-
-post-install:
        @${MKDIR} ${STAGEDIR}${SMFSAV_RUN_DIR}
-.if ${PORT_OPTIONS:MDOCS}
        @${MKDIR} ${STAGEDIR}${DOCSDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ChangeLog readme ${STAGEDIR}${DOCSDIR}
-.endif

 .include <bsd.port.mk>
diff -ruN smfsav.orig/files/pkg-message.in smfsav/files/pkg-message.in
--- smfsav.orig/files/pkg-message.in    2015-05-29 21:20:18.464386000 +0300
+++ smfsav/files/pkg-message.in 2015-05-29 21:12:35.276515000 +0300
@@ -5,5 +5,5 @@
     define(`confMILTER_MACROS_HELO', confMILTER_MACROS_HELO`, {verify}')dnl
     INPUT_MAIL_FILTER(`smfsav', `S=unix:/var/run/smfsav/smfsav.sock,
T=S:30s;R:4m')dnl
 3. Put line smfsav_enable="YES" to /etc/rc.conf file
-4. Run service smfsav start
+4. Run `service smfsav start`

=====================================================================================

-- 
You are receiving this mail because:
You are the assignee for the bug.